On Nov 5, 2008, at 12:34 PM, Kenneth Marshall wrote:
I am using the anonymous CVS repository, it returns the following
information in pg_catalog.pg_settings:
What is lc_collate set to?
% show lc_collate;
FWIW, I just ran the tests myself and all passed, with and without the
patch (using
On Fri, Nov 07, 2008 at 10:15:17AM -0800, David E. Wheeler wrote:
On Nov 5, 2008, at 12:34 PM, Kenneth Marshall wrote:
I am using the anonymous CVS repository, it returns the following
information in pg_catalog.pg_settings:
What is lc_collate set to?
% show lc_collate;
FWIW, I just ran
On Nov 7, 2008, at 10:43 AM, Kenneth Marshall wrote:
Thank you for the pointers. lc_collate is set to en_US.UTF-8.
Huh. Same as for me.
I re-initdb the database with the --no-locale option and then the
tests passed successfully. Thank you for the reminder that the
regression tests need to
Kenneth Marshall [EMAIL PROTECTED] writes:
Thank you for the pointers. lc_collate is set to en_US.UTF-8. I
re-initdb the database with the --no-locale option and then the
tests passed successfully. Thank you for the reminder that the
regression tests need to run against a C locale database.
On Nov 7, 2008, at 11:15 AM, Tom Lane wrote:
In a quick test on a Fedora box, citext is the only core or contrib
test
that fails in en_US. (This is true in HEAD, even without having
applied
the proposed patch.) It would be good to clean that up.
Huh. There must be something different
David E. Wheeler [EMAIL PROTECTED] writes:
Huh. There must be something different about the collation for en_US
on Fedora than there is for darwin (what I'm using), because for me,
as I said, all tests pass.
Yeah, Darwin seems to just use ASCII sort order in en_US (couldn't say
about its
On Nov 7, 2008, at 11:50 AM, Tom Lane wrote:
This is why I like TAP.
And how would TAP reduce the number of expected results?
TAP doesn't compare output to expected output files. It's simply a
test result output stream. A separate program then harnesses that
output, looks at what passed
David E. Wheeler [EMAIL PROTECTED] writes:
On Nov 7, 2008, at 11:50 AM, Tom Lane wrote:
And how would TAP reduce the number of expected results?
TAP doesn't compare output to expected output files. It's simply a
test result output stream. A separate program then harnesses that
output,
On Nov 7, 2008, at 12:12 PM, Tom Lane wrote:
... and you have very limited visibility into what went wrong, if
anything goes wrong. That's not real attractive for the buildfarm
environment. I like being able to see the actual query output.
It depends on how you write it - you can add a lot
David E. Wheeler [EMAIL PROTECTED] writes:
On Nov 7, 2008, at 11:15 AM, Tom Lane wrote:
My inclination is to remove the XML-dependent citext tests, which don't
seem especially useful, and then we can have whatever variants we need
for locales. citext locale behavior seems much more
On Nov 7, 2008, at 3:18 PM, Tom Lane wrote:
Agreed, but I admit to being mystified as to why things would be
sorting any differently on darwin vs. Fedora. I kept everything in
ASCII, on your advice, to keep from having to deal with crap like
this.
Patch applied with this adjustment.
David E. Wheeler [EMAIL PROTECTED] writes:
On Nov 7, 2008, at 3:18 PM, Tom Lane wrote:
Patch applied with this adjustment.
Great. So does it now pass all tests on Fedora?
Yeah, I checked with both C and en_US.utf8 locales. It's likely that
these two cases will cover them all, though I was
I installed and ran the citext tests both with and without
the patch and had failures both times. The patch applied
cleanly and the make;make install completed without errors.
I have attached the two regression.diffs files, one without
the patch applied and the other with the patch.
Regards,
Ken
On Nov 5, 2008, at 6:40 AM, Kenneth Marshall wrote:
I installed and ran the citext tests both with and without
the patch and had failures both times. The patch applied
cleanly and the make;make install completed without errors.
I have attached the two regression.diffs files, one without
the
On Wed, Nov 05, 2008 at 09:04:04AM -0800, David E. Wheeler wrote:
On Nov 5, 2008, at 6:40 AM, Kenneth Marshall wrote:
I installed and ran the citext tests both with and without
the patch and had failures both times. The patch applied
cleanly and the make;make install completed without errors.
15 matches
Mail list logo
