Re: [HACKERS] Time based lag tracking for logical replication

On Sat, May 13, 2017 at 12:04 AM, Petr Jelinek wrote: > > After this commit 024711bb544645c8b1061e9f02b261e2e336981d I get > > following error while executing CREATE SUBSCRIPTION: > > > > CREATE SUBSCRIPTION sub1 CONNECTION 'dbname=postgres host=localhost > >

Re: [HACKERS] Time based lag tracking for logical replication

On 12/05/17 15:09, Neha Khatri wrote: > On Fri, May 12, 2017 at 8:19 PM, Simon Riggs wrote: >> >> On 11 May 2017 at 18:29, Simon Riggs wrote: >>> On 11 May 2017 at 18:13, Andres Freund wrote: >>> > New patch, v3. > >

Re: [HACKERS] Time based lag tracking for logical replication

On Fri, May 12, 2017 at 8:19 PM, Simon Riggs wrote: > > On 11 May 2017 at 18:29, Simon Riggs wrote: > > On 11 May 2017 at 18:13, Andres Freund wrote: > > > >>>New patch, v3. > >>> > >>>Applying in 90 minutes, barring objections.

Re: [HACKERS] Time based lag tracking for logical replication

On 11 May 2017 at 18:29, Simon Riggs wrote: > On 11 May 2017 at 18:13, Andres Freund wrote: > >>>New patch, v3. >>> >>>Applying in 90 minutes, barring objections. >> >> Could you please wait till tomorrow? I've bigger pending fixes for related >> code

Re: [HACKERS] Time based lag tracking for logical replication

On 11 May 2017 at 18:13, Andres Freund wrote: >>New patch, v3. >> >>Applying in 90 minutes, barring objections. > > Could you please wait till tomorrow? I've bigger pending fixes for related > code pending/being tested that I plan to push today. I'd also like to take a >

Re: [HACKERS] Time based lag tracking for logical replication

On May 11, 2017 8:08:11 AM PDT, Simon Riggs wrote: >On 11 May 2017 at 14:12, Petr Jelinek >wrote: > >>> Attached patch is Petr's patch, slightly rebased with added pacing >>> delay, similar to that used by HSFeedback. >>> >> >> This looks

Re: [HACKERS] Time based lag tracking for logical replication

On 11 May 2017 at 14:12, Petr Jelinek wrote: >> Attached patch is Petr's patch, slightly rebased with added pacing >> delay, similar to that used by HSFeedback. >> > > This looks reasonable. I would perhaps change: >> + /* >> +* Track lag no more than

Re: [HACKERS] Time based lag tracking for logical replication

On 11/05/17 15:01, Simon Riggs wrote: > On 11 May 2017 at 08:32, Noah Misch wrote: >> On Sun, Apr 23, 2017 at 01:10:32AM +0200, Petr Jelinek wrote: >>> The time based lag tracking commit [1] added interface for logging >>> progress of replication so that we can report lag as

Re: [HACKERS] Time based lag tracking for logical replication

On 11 May 2017 at 08:32, Noah Misch wrote: > On Sun, Apr 23, 2017 at 01:10:32AM +0200, Petr Jelinek wrote: >> The time based lag tracking commit [1] added interface for logging >> progress of replication so that we can report lag as time interval >> instead of just bytes. But

Re: [HACKERS] Time based lag tracking for logical replication

On Sun, Apr 23, 2017 at 01:10:32AM +0200, Petr Jelinek wrote: > The time based lag tracking commit [1] added interface for logging > progress of replication so that we can report lag as time interval > instead of just bytes. But the patch didn't contain patch for the > builtin logical replication.

Re: [HACKERS] Time based lag tracking for logical replication

On Mon, May 08, 2017 at 10:30:45PM -0700, Noah Misch wrote: > On Fri, May 05, 2017 at 07:07:26AM +, Noah Misch wrote: > > On Wed, May 03, 2017 at 08:28:53AM +0200, Simon Riggs wrote: > > > On 23 April 2017 at 01:10, Petr Jelinek > > > wrote: > > > > Hi, > > > >

Re: [HACKERS] Time based lag tracking for logical replication

On Fri, May 05, 2017 at 07:07:26AM +, Noah Misch wrote: > On Wed, May 03, 2017 at 08:28:53AM +0200, Simon Riggs wrote: > > On 23 April 2017 at 01:10, Petr Jelinek > > wrote: > > > Hi, > > > > > > The time based lag tracking commit [1] added interface for logging

Re: [HACKERS] Time based lag tracking for logical replication

On Wed, May 03, 2017 at 08:28:53AM +0200, Simon Riggs wrote: > On 23 April 2017 at 01:10, Petr Jelinek wrote: > > Hi, > > > > The time based lag tracking commit [1] added interface for logging > > progress of replication so that we can report lag as time interval > >

Re: [HACKERS] Time based lag tracking for logical replication

On 03/05/17 08:28, Simon Riggs wrote: > On 23 April 2017 at 01:10, Petr Jelinek wrote: >> Hi, >> >> The time based lag tracking commit [1] added interface for logging >> progress of replication so that we can report lag as time interval >> instead of just bytes. But

Re: [HACKERS] Time based lag tracking for logical replication

On Wed, May 3, 2017 at 6:28 PM, Simon Riggs wrote: > On 23 April 2017 at 01:10, Petr Jelinek wrote: >> Hi, >> >> The time based lag tracking commit [1] added interface for logging >> progress of replication so that we can report lag as time

Re: [HACKERS] Time based lag tracking for logical replication

On 23 April 2017 at 01:10, Petr Jelinek wrote: > Hi, > > The time based lag tracking commit [1] added interface for logging > progress of replication so that we can report lag as time interval > instead of just bytes. But the patch didn't contain patch for the >

Re: [HACKERS] Time based lag tracking for logical replication

On 23/04/17 01:10, Petr Jelinek wrote: > Hi, > > The time based lag tracking commit [1] added interface for logging > progress of replication so that we can report lag as time interval > instead of just bytes. But the patch didn't contain patch for the > builtin logical replication. > > So I

[HACKERS] Time based lag tracking for logical replication

Hi, The time based lag tracking commit [1] added interface for logging progress of replication so that we can report lag as time interval instead of just bytes. But the patch didn't contain patch for the builtin logical replication. So I wrote something that implements this. I didn't like all