Re: [HACKERS] Time to get rid of PQnoPasswordSupplied?

2015-06-23 Thread Craig Ringer
On 22 June 2015 at 22:00, Tom Lane wrote: > I do not follow Craig's argument that this is somehow connected to the > wire protocol version. Upon revisiting it, neither do I. You know when you read code and think "what idiot wrote this" ... then "git blame" says it was you? I, at least, know tha

Re: [HACKERS] Time to get rid of PQnoPasswordSupplied?

2015-06-22 Thread Jim Nasby
On 6/22/15 9:00 AM, Tom Lane wrote: Jim Nasby writes: On 6/19/15 10:35 AM, Tom Lane wrote: On the other hand, you could argue that improving the string is going to break clients that do the right thing (even if klugily) in order to help clients that are doing the wrong thing (ie, failing witho

Re: [HACKERS] Time to get rid of PQnoPasswordSupplied?

2015-06-22 Thread Tom Lane
Jim Nasby writes: > On 6/19/15 10:35 AM, Tom Lane wrote: >> On the other hand, you could argue that improving the string is going >> to break clients that do the right thing (even if klugily) in order >> to help clients that are doing the wrong thing (ie, failing without >> offering the opportunit

Re: [HACKERS] Time to get rid of PQnoPasswordSupplied?

2015-06-21 Thread Jim Nasby
On 6/19/15 10:35 AM, Tom Lane wrote: On the other hand, you could argue that improving the string is going to break clients that do the right thing (even if klugily) in order to help clients that are doing the wrong thing (ie, failing without offering the opportunity to enter a password). Ideall

Re: [HACKERS] Time to get rid of PQnoPasswordSupplied?

2015-06-21 Thread Craig Ringer
On 19 June 2015 at 22:35, Tom Lane wrote: > Robert Haas writes: >> On Sun, Jun 14, 2015 at 11:34 PM, Craig Ringer wrote: >>> I frequently see users confused by one of our more common and less >>> clear error messages: >>> >>> fe_sendauth: no password supplied > >> I've never seen this error mess

Re: [HACKERS] Time to get rid of PQnoPasswordSupplied?

2015-06-19 Thread Tom Lane
Robert Haas writes: > On Sun, Jun 14, 2015 at 11:34 PM, Craig Ringer wrote: >> I frequently see users confused by one of our more common and less >> clear error messages: >> >> fe_sendauth: no password supplied > I've never seen this error message, but I'm not opposed to improving > it in some

Re: [HACKERS] Time to get rid of PQnoPasswordSupplied?

2015-06-19 Thread Robert Haas
On Sun, Jun 14, 2015 at 11:34 PM, Craig Ringer wrote: > I frequently see users confused by one of our more common and less > clear error messages: > > fe_sendauth: no password supplied I've never seen this error message, but I'm not opposed to improving it in some way. -- Robert Haas Enterp

[HACKERS] Time to get rid of PQnoPasswordSupplied?

2015-06-14 Thread Craig Ringer
Hi all I frequently see users confused by one of our more common and less clear error messages: fe_sendauth: no password supplied What this really means is that the server requested a password for md5 or cleartext authentication but no password was supplied to the client and it cannot prompt