[HACKERS] Tweaking ResolveNew's API

2012-11-08 Thread Tom Lane
The submitted patch for auto-updatable views uses rewriteManip.c's ResolveNew() function to replace Vars referencing the view with Vars referencing the underlying table. That's mostly all right, except that ResolveNew has some hard-wired choices about what it should do if a Var to be replaced

Re: [HACKERS] Tweaking ResolveNew's API

2012-11-08 Thread Alvaro Herrera
Tom Lane wrote: A possible objection to this is that most C compilers wouldn't complain if a call site is still trying to use the old convention of passing a CmdType value. In the core code, there are only four call sites and three are in rewriteHandler.c itself, so this isn't much of a

Re: [HACKERS] Tweaking ResolveNew's API

2012-11-08 Thread Tom Lane
Alvaro Herrera alvhe...@2ndquadrant.com writes: Tom Lane wrote: A possible objection to this is that most C compilers wouldn't complain if a call site is still trying to use the old convention of passing a CmdType value. In the core code, there are only four call sites and three are in

Re: [HACKERS] Tweaking ResolveNew's API

2012-11-08 Thread David Fetter
On Thu, Nov 08, 2012 at 02:35:34PM -0500, Tom Lane wrote: Alvaro Herrera alvhe...@2ndquadrant.com writes: Tom Lane wrote: A possible objection to this is that most C compilers wouldn't complain if a call site is still trying to use the old convention of passing a CmdType value. In the