Re: [HACKERS] Typo in comment in xlog.c: ReadRecord
On 2017/07/01 3:49, Peter Eisentraut wrote: > On 6/27/17 20:54, Amit Langote wrote: >> Attached fixes $SUBJECT. >> >> s/fetch_ckpt/fetching_ckpt/g > > committed Thanks. Regards, Amit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment in postgres_fdw.c
On 6/28/17 09:53, Albe Laurenz wrote: > Attached is a fix for a small typo I found. committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment in xlog.c: ReadRecord
On 6/27/17 20:54, Amit Langote wrote: > Attached fixes $SUBJECT. > > s/fetch_ckpt/fetching_ckpt/g committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Typo in comment in postgres_fdw.c
Attached is a fix for a small typo I found. Yours, Laurenz Albe comment.patch Description: comment.patch -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Typo in comment in xlog.c: ReadRecord
Attached fixes $SUBJECT. s/fetch_ckpt/fetching_ckpt/g Thanks, Amit diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 0a6314a642..5b6cec8dee 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -4221,10 +4221,10 @@ ReadRecord(XLogReaderState *xlogreader, XLogRecPtr RecPtr, int emode, * pg_wal, so we are presumably now consistent. * * We require that there's at least some valid WAL present in -* pg_wal, however (!fetch_ckpt). We could recover using the WAL -* from the archive, even if pg_wal is completely empty, but we'd -* have no idea how far we'd have to replay to reach consistency. -* So err on the safe side and give up. +* pg_wal, however (!fetching_ckpt). We could recover using the +* WAL from the archive, even if pg_wal is completely empty, but +* we'd have no idea how far we'd have to replay to reach +* consistency. So err on the safe side and give up. */ if (!InArchiveRecovery && ArchiveRecoveryRequested && !fetching_ckpt) -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment in ecpg datetime.c
On 6/15/17 04:54, Daniel Gustafsson wrote: > Spotted s/fiedls/fields/ in src/interfaces/ecpg/pgtypeslib/datetime.c per the > attached patch. fixed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Typo in comment in ecpg datetime.c
Spotted s/fiedls/fields/ in src/interfaces/ecpg/pgtypeslib/datetime.c per the attached patch. cheers ./daniel typo-ecpg_datetime.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment in postgres_fdw.c
On Thu, Jan 26, 2017 at 10:45 PM, Etsuro Fujitawrote: > I ran into a typo in a comment in contrib/postgres_fdw/postgres_fdw.c. > Attached is a small patch for fixing that. Committed, thanks. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Typo in comment in postgres_fdw.c
Hi, I ran into a typo in a comment in contrib/postgres_fdw/postgres_fdw.c. Attached is a small patch for fixing that. Best regards, Etsuro Fujita diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c index fbe6929..7cb9dc5 100644 --- a/contrib/postgres_fdw/postgres_fdw.c +++ b/contrib/postgres_fdw/postgres_fdw.c @@ -4218,7 +4218,7 @@ foreign_join_ok(PlannerInfo *root, RelOptInfo *joinrel, JoinType jointype, /* * If user is willing to estimate cost for a scan of either of the joining * relations using EXPLAIN, he intends to estimate scans on that relation - * more accurately. Then, it makes sense to estimate the cost the join + * more accurately. Then, it makes sense to estimate the cost of the join * with that relation more accurately using EXPLAIN. */ fpinfo->use_remote_estimate = fpinfo_o->use_remote_estimate || -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment
On Fri, Nov 25, 2016 at 4:10 AM, Thomas Munrowrote: > Hi > > Here is a tiny patch to fix a typo in execParallel.c. > Applied, thanks. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/
[HACKERS] Typo in comment
Hi Here is a tiny patch to fix a typo in execParallel.c. -- Thomas Munro http://www.enterprisedb.com typo.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment in file analyze.c [master branch]
Kostiantyn Nemchenkowrites: > I've found a typo in a comment in function do_analyze_rel() in > file analyze.c [line 348, master branch]. No, "iff" is intentional there. It means "if and only if". regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Typo in comment in file analyze.c [master branch]
I've found a typo in a comment in function do_analyze_rel() in file analyze.c [line 348, master branch]. Attached a patch. minor_typo_analyze_c.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment in contrib/postgres_fdw/deparse.c
On 2016/11/04 22:04, Robert Haas wrote: On Fri, Nov 4, 2016 at 7:20 AM, Etsuro Fujitawrote: I found another typo in postgres_fdw.c. Attached is a patch for fixing that. OK, committed that, too. Thanks again! Best regards, Etsuro Fujita -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment in contrib/postgres_fdw/deparse.c
On Fri, Nov 4, 2016 at 7:20 AM, Etsuro Fujitawrote: > On 2016/11/02 5:22, Robert Haas wrote: >> On Tue, Nov 1, 2016 at 8:20 AM, Etsuro Fujita >> wrote: >>> >>> I ran into a typo in a comment in contrib/postgres_fdw/deparse.c. Please >>> find attached a patch. > >> Committed. > > Thanks! > > I found another typo in postgres_fdw.c. Attached is a patch for fixing > that. OK, committed that, too. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment in contrib/postgres_fdw/deparse.c
On 2016/11/02 5:22, Robert Haas wrote: On Tue, Nov 1, 2016 at 8:20 AM, Etsuro Fujitawrote: I ran into a typo in a comment in contrib/postgres_fdw/deparse.c. Please find attached a patch. Committed. Thanks! I found another typo in postgres_fdw.c. Attached is a patch for fixing that. Best regards, Etsuro Fujita diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c index 2cfb82b..fbe6929 100644 --- a/contrib/postgres_fdw/postgres_fdw.c +++ b/contrib/postgres_fdw/postgres_fdw.c @@ -4156,7 +4156,7 @@ foreign_join_ok(PlannerInfo *root, RelOptInfo *joinrel, JoinType jointype, * other remote clauses. For LEFT and RIGHT OUTER join, the clauses from * the outer side are added to remote_conds since those can be evaluated * after the join is evaluated. The clauses from inner side are added to - * the joinclauses, since they need to evaluated while constructing the + * the joinclauses, since they need to be evaluated while constructing the * join. * * For a FULL OUTER JOIN, the other clauses from either relation can not -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment in contrib/postgres_fdw/deparse.c
On Tue, Nov 1, 2016 at 8:20 AM, Etsuro Fujitawrote: > I ran into a typo in a comment in contrib/postgres_fdw/deparse.c. Please > find attached a patch. Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Typo in comment in contrib/postgres_fdw/deparse.c
Hi, I ran into a typo in a comment in contrib/postgres_fdw/deparse.c. Please find attached a patch. Best regards, Etsuro Fujita diff --git a/contrib/postgres_fdw/deparse.c b/contrib/postgres_fdw/deparse.c index 450693a..66b059a 100644 --- a/contrib/postgres_fdw/deparse.c +++ b/contrib/postgres_fdw/deparse.c @@ -847,7 +847,7 @@ deparse_type_name(Oid type_oid, int32 typemod) * * The output targetlist contains the columns that need to be fetched from the * foreign server for the given relation. If foreignrel is an upper relation, - * then the output targetlist can also contains expressions to be evaluated on + * then the output targetlist can also contain expressions to be evaluated on * foreign server. */ List * -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment to function LockHasWaitersRelation() [master branch]
On Mon, Aug 22, 2016 at 9:01 AM, Dmitry Ivanovwrote: >> Hi hackers, >> >> I've found a typo in a comment to function LockHasWaitersRelation() [lmgr.c >> : >> 271, master branch]: >> >> This is a functiion to check > > Attached a patch. Thanks. Committed with a bit of additional wordsmithing. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment to function LockHasWaitersRelation() [master branch]
> Hi hackers, > > I've found a typo in a comment to function LockHasWaitersRelation() [lmgr.c > : > 271, master branch]: > >> This is a functiion to check Attached a patch. -- Dmitry Ivanov Postgres Professional: http://www.postgrespro.com Russian Postgres Companydiff --git a/src/backend/storage/lmgr/lmgr.c b/src/backend/storage/lmgr/lmgr.c index 7b08555..d0fdb94 100644 --- a/src/backend/storage/lmgr/lmgr.c +++ b/src/backend/storage/lmgr/lmgr.c @@ -268,7 +268,7 @@ UnlockRelation(Relation relation, LOCKMODE lockmode) /* * LockHasWaitersRelation * - * This is a functiion to check if someone else is waiting on a + * This is a function to check if someone else is waiting on a * lock, we are currently holding. */ bool -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Typo in comment to function LockHasWaitersRelation() [master branch]
Hi hackers, I've found a typo in a comment to function LockHasWaitersRelation() [lmgr.c : 271, master branch]: >> This is a functiion to check -- Dmitry Ivanov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment in nbtree.h
On Wed, Jun 1, 2016 at 4:08 PM, Thomas Munrowrote: > Maybe it should be like this? > > --- a/src/include/access/nbtree.h > +++ b/src/include/access/nbtree.h > @@ -522,7 +522,7 @@ typedef struct BTScanPosData > Buffer buf;/* if valid, the > buffer is pinned */ > > XLogRecPtr lsn;/* pos in the WAL > stream when page was read */ > - BlockNumber currPage; /* page we've referencd by > items array */ > + BlockNumber currPage; /* page referenced by items array */ > BlockNumber nextPage; /* page's right link when we > scanned it */ > > /* I agree. Pushed. Thanks! -- Kevin Grittner EDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Typo in comment in nbtree.h
Hi Following along with a btree bug report, I saw a typo "referencd" in a comment. Also "we've" seems a bit odd here, but maybe it's just me. Maybe it should be like this? --- a/src/include/access/nbtree.h +++ b/src/include/access/nbtree.h @@ -522,7 +522,7 @@ typedef struct BTScanPosData Buffer buf;/* if valid, the buffer is pinned */ XLogRecPtr lsn;/* pos in the WAL stream when page was read */ - BlockNumber currPage; /* page we've referencd by items array */ + BlockNumber currPage; /* page referenced by items array */ BlockNumber nextPage; /* page's right link when we scanned it */ /* -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment
On Sat, Mar 26, 2016 at 4:21 PM, Thomas Munrowrote: > Here are a couple of patches to fix a typo in a comment in latch.c: > > - * The memory barrier has be to be placed here to ensure that any flag > + * The memory barrier has to be placed here to ensure that any flag Committed, but it hardly seems worth back-patching. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Typo in comment
Hi, Here are a couple of patches to fix a typo in a comment in latch.c: - * The memory barrier has be to be placed here to ensure that any flag + * The memory barrier has to be placed here to ensure that any flag Thanks, -- Thomas Munro http://www.enterprisedb.com typo.patch Description: Binary data typo-backbranches.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment
On Fri, Mar 4, 2016 at 2:39 PM, Thomas Munrowrote: > Here is a patch to fix a typo in a comment in timestamp.c. That looks like a typo, all right. Committed. (It's "commit small patches day" for me today, in case anybody hasn't caught on to that already...) -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Typo in comment
Hi Here is a patch to fix a typo in a comment in timestamp.c. -- Thomas Munro http://www.enterprisedb.com typo.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment in ATPrepChangePersistence
On 07/29/2015 05:26 AM, Amit Langote wrote: Attached fixes a typo: - * no permanent tables cannot reference unlogged ones. + * permanent tables cannot reference unlogged ones. Thanks, fixed. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Typo in comment in ATPrepChangePersistence
Hi, Attached fixes a typo: - * no permanent tables cannot reference unlogged ones. + * permanent tables cannot reference unlogged ones. Thanks, Amit diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index 1c7eded..b459b1e 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -11169,7 +11169,7 @@ ATPrepChangePersistence(Relation rel, bool toLogged) /* * Check existing foreign key constraints to preserve the invariant that - * no permanent tables cannot reference unlogged ones. Self-referencing + * permanent tables cannot reference unlogged ones. Self-referencing * foreign keys can safely be ignored. */ pg_constraint = heap_open(ConstraintRelationId, AccessShareLock); -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment in setrefs.c
On 2015/07/21 1:38, Alvaro Herrera wrote: Etsuro Fujita wrote: I ran into a typo in a comment in setrefs.c. Patch attached. Fixed by Heikki in 7845db2aa. Thank you for letting me know about that, Alvaro! And thanks Heikki for picking this up! Best regards, Etsuro Fujita -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment in setrefs.c
Etsuro Fujita wrote: I ran into a typo in a comment in setrefs.c. Patch attached. Fixed by Heikki in 7845db2aa. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Typo in comment in setrefs.c
I ran into a typo in a comment in setrefs.c. Patch attached. Best regards, Etsuro Fujita diff --git a/src/backend/optimizer/plan/setrefs.c b/src/backend/optimizer/plan/setrefs.c index a7f65dd..162a52e 100644 --- a/src/backend/optimizer/plan/setrefs.c +++ b/src/backend/optimizer/plan/setrefs.c @@ -1452,7 +1452,7 @@ fix_scan_expr_walker(Node *node, fix_scan_expr_context *context) * subplans, by setting the varnos to OUTER_VAR or INNER_VAR and setting * attno values to the result domain number of either the corresponding * outer or inner join tuple item. Also perform opcode lookup for these - * expressions. and add regclass OIDs to root-glob-relationOids. + * expressions, and add regclass OIDs to root-glob-relationOids. */ static void set_join_references(PlannerInfo *root, Join *join, int rtoffset) -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Typo in comment
I ran into a typo in a comment in src/backend/commands/matview.c. Please find attached a patch. Best regards, Etsuro Fujita diff --git a/src/backend/commands/matview.c b/src/backend/commands/matview.c index 30bd40d..db05f7c 100644 --- a/src/backend/commands/matview.c +++ b/src/backend/commands/matview.c @@ -473,7 +473,7 @@ transientrel_destroy(DestReceiver *self) * the given integer, to make a new table name based on the old one. * * This leaks memory through palloc(), which won't be cleaned up until the - * current memory memory context is freed. + * current memory context is freed. */ static char * make_temptable_name_n(char *tempname, int n) -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Typo in comment
On Thu, Nov 6, 2014 at 7:44 PM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: I ran into a typo in a comment in src/backend/commands/matview.c. Please find attached a patch. Thanks! Applied. Best regards, Etsuro Fujita -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers