Re: [HACKERS] Typos in src/backend/optimizer/README

2017-10-29 Thread Etsuro Fujita 

On 2017/10/28 18:15, Robert Haas wrote:

On Fri, Oct 27, 2017 at 9:34 AM, Etsuro Fujita
 wrote:

This sentence in the section of Partition-wise joins in
src/backend/optimizer/README should be fixed: "This technique of breaking
down a join between partition tables into join between their partitions is
called partition-wise join."

(1) s/a join between partition tables/a join between partitioned tables/
(2) s/join between their partitions/joins between their partitions/

It might be okay to leave #2 as-is, but I'd like to propose to change that
way to make the meaning clear.


I think you are right.  I have committed the patch.


Thank you.

Best regards,
Etsuro Fujita



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typos in src/backend/optimizer/README

2017-10-28 Thread Robert Haas 
On Fri, Oct 27, 2017 at 9:34 AM, Etsuro Fujita
 wrote:
> This sentence in the section of Partition-wise joins in
> src/backend/optimizer/README should be fixed: "This technique of breaking
> down a join between partition tables into join between their partitions is
> called partition-wise join."
>
> (1) s/a join between partition tables/a join between partitioned tables/
> (2) s/join between their partitions/joins between their partitions/
>
> It might be okay to leave #2 as-is, but I'd like to propose to change that
> way to make the meaning clear.

I think you are right.  I have committed the patch.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Typos in src/backend/optimizer/README

2017-10-27 Thread Etsuro Fujita 

Hi,

This sentence in the section of Partition-wise joins in 
src/backend/optimizer/README should be fixed: "This technique of 
breaking down a join between partition tables into join between their 
partitions is called partition-wise join."


(1) s/a join between partition tables/a join between partitioned tables/
(2) s/join between their partitions/joins between their partitions/

It might be okay to leave #2 as-is, but I'd like to propose to change 
that way to make the meaning clear.


Attached is a patch for that.

Best regards,
Etsuro Fujita
diff --git a/src/backend/optimizer/README b/src/backend/optimizer/README
index 031e503..1e4084d 100644
--- a/src/backend/optimizer/README
+++ b/src/backend/optimizer/README
@@ -1088,8 +1088,8 @@ broken into joins between the matching partitions. The 
resultant join is
 partitioned in the same way as the joining relations, thus allowing an N-way
 join between similarly partitioned tables having equi-join condition between
 their partition keys to be broken down into N-way joins between their matching
-partitions. This technique of breaking down a join between partition tables
-into join between their partitions is called partition-wise join. We will use
+partitions. This technique of breaking down a join between partitioned tables
+into joins between their partitions is called partition-wise join. We will use
 term "partitioned relation" for either a partitioned table or a join between
 compatibly partitioned tables.
 

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers