Re: [HACKERS] USE_LIBXSLT in MSVC builds

2010-03-04 Thread Dave Page
On Wed, Mar 3, 2010 at 12:18 PM, Andrew Dunstan and...@dunslane.net wrote: I think these might need to have c:\pgBuild\{libxslt,iconv}\bin added to the PATH in the buildfarm.conf file, right after where c:\pgBuild\libxml2\bin is added. This is now done. Sorry for the delay. -- Dave Page

Re: [HACKERS] USE_LIBXSLT in MSVC builds

2010-03-04 Thread Andrew Dunstan
Dave Page wrote: On Wed, Mar 3, 2010 at 12:18 PM, Andrew Dunstan and...@dunslane.net wrote: I think these might need to have c:\pgBuild\{libxslt,iconv}\bin added to the PATH in the buildfarm.conf file, right after where c:\pgBuild\libxml2\bin is added. This is now done. Sorry for

Re: [HACKERS] USE_LIBXSLT in MSVC builds

2010-03-03 Thread Magnus Hagander
2010/3/3 Andrew Dunstan and...@dunslane.net: Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Baiji is now failing, however. Perhaps it is not finding the XSLT lib or dll? Curious indeed, because it passed yesterday, *after* I had made all those changes in contrib/xml2

Re: [HACKERS] USE_LIBXSLT in MSVC builds

2010-03-03 Thread Andrew Dunstan
Magnus Hagander wrote: 2010/3/3 Andrew Dunstan and...@dunslane.net: Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Baiji is now failing, however. Perhaps it is not finding the XSLT lib or dll? Curious indeed, because it passed yesterday, *after* I had

Re: [HACKERS] USE_LIBXSLT in MSVC builds

2010-03-03 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: It's not working on mastodon, and presumably will fail again on baiji. I notice that mastodon does not appear to have the presumed location of the iconv and xslt DLLs in the PATH it sets. That would be a plausible explanation of the problem ;-)

Re: [HACKERS] USE_LIBXSLT in MSVC builds

2010-03-03 Thread Yeb Havinga
Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: It's not working on mastodon, and presumably will fail again on baiji. I notice that mastodon does not appear to have the presumed location of the iconv and xslt DLLs in the PATH it sets. That would be a plausible

Re: [HACKERS] USE_LIBXSLT in MSVC builds

2010-03-02 Thread Andrew Dunstan
Tom Lane wrote: BTW, it looks like the MSVC build scripts don't bother to make sure that USE_LIBXSLT is defined (or not) correctly --- at least I can't see any reference to that symbol in the Windows-specific files. This is now necessary to avoid disabling the xslt functionality in

Re: [HACKERS] USE_LIBXSLT in MSVC builds

2010-03-02 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: BTW, it looks like the MSVC build scripts don't bother to make sure that USE_LIBXSLT is defined (or not) correctly --- at least I can't see any reference to that symbol in the Windows-specific files. This is now necessary to avoid

Re: [HACKERS] USE_LIBXSLT in MSVC builds

2010-03-02 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: BTW, it looks like the MSVC build scripts don't bother to make sure that USE_LIBXSLT is defined (or not) correctly --- at least I can't see any reference to that symbol in the Windows-specific files. This is

Re: [HACKERS] USE_LIBXSLT in MSVC builds

2010-03-02 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: Also, mastodon is still failing the xml2 test, not sure why. Looks to be a build problem, but why is (for instance) baiji unaffected? Baiji built before I put in the patch, so it didn't have USE_LIBXSLT enabled. But mastodon is

Re: [HACKERS] USE_LIBXSLT in MSVC builds

2010-03-02 Thread Tom Lane
BTW, now that I look at red_bat's failure, it seems that the MSVC build scripts try to run the contrib/xml2 test even when xml2 hasn't been built for lack of libxml. This doesn't explain mastodon's problem but maybe a second look is needed at all the conditionals around that.

Re: [HACKERS] USE_LIBXSLT in MSVC builds

2010-03-02 Thread Andrew Dunstan
Tom Lane wrote: BTW, now that I look at red_bat's failure, it seems that the MSVC build scripts try to run the contrib/xml2 test even when xml2 hasn't been built for lack of libxml. This doesn't explain mastodon's problem but maybe a second look is needed at all the conditionals around that.

Re: [HACKERS] USE_LIBXSLT in MSVC builds

2010-03-02 Thread Andrew Dunstan
Andrew Dunstan wrote: Tom Lane wrote: BTW, now that I look at red_bat's failure, it seems that the MSVC build scripts try to run the contrib/xml2 test even when xml2 hasn't been built for lack of libxml. This doesn't explain mastodon's problem but maybe a second look is needed at all the

Re: [HACKERS] USE_LIBXSLT in MSVC builds

2010-03-02 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: Baiji is now failing, however. Perhaps it is not finding the XSLT lib or dll? Curious indeed, because it passed yesterday, *after* I had made all those changes in contrib/xml2 itself. The only deltas since then are your MSVC script additions. Now

Re: [HACKERS] USE_LIBXSLT in MSVC builds

2010-03-02 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Baiji is now failing, however. Perhaps it is not finding the XSLT lib or dll? Curious indeed, because it passed yesterday, *after* I had made all those changes in contrib/xml2 itself. The only deltas since then are your

[HACKERS] USE_LIBXSLT in MSVC builds

2010-03-01 Thread Tom Lane
BTW, it looks like the MSVC build scripts don't bother to make sure that USE_LIBXSLT is defined (or not) correctly --- at least I can't see any reference to that symbol in the Windows-specific files. This is now necessary to avoid disabling the xslt functionality in contrib/xml2. I'm not too sure