Re: [HACKERS] Unused variables in hstore_to_jsonb

2015-01-13 Thread Michael Paquier
On Tue, Jan 13, 2015 at 5:36 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: You'll need to use (void) pushJsonbValue(...), otherwise you'll just get a different warning. See commit c8315930. Oh, I see. So this portion in contrib/ has been visibly missing. Attached is a new patch. --

Re: [HACKERS] Unused variables in hstore_to_jsonb

2015-01-13 Thread Heikki Linnakangas
On 01/13/2015 01:09 PM, Michael Paquier wrote: On Tue, Jan 13, 2015 at 5:36 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: You'll need to use (void) pushJsonbValue(...), otherwise you'll just get a different warning. See commit c8315930. Oh, I see. So this portion in contrib/ has been

[HACKERS] Unused variables in hstore_to_jsonb

2015-01-12 Thread Michael Paquier
Hi all, Coverity pointed out that hstore_to_jsonb in hstore_io.c does not use a couple of return values from pushJsonbValue. Attached is a patch to fix that. Regards, -- Michael *** a/contrib/hstore/hstore_io.c --- b/contrib/hstore/hstore_io.c *** *** 1338,1344

Re: [HACKERS] Unused variables in hstore_to_jsonb

2015-01-12 Thread Michael Paquier
On Tue, Jan 13, 2015 at 4:34 PM, Michael Paquier michael.paqu...@gmail.com wrote: Attached is a patch to fix that. Oh, actually that's as well the case of hstore_to_jsonb_loose. Updated patch is attached. -- Michael *** a/contrib/hstore/hstore_io.c --- b/contrib/hstore/hstore_io.c