Re: [HACKERS] Updating line length guidelines

2017-08-24 Thread Tom Lane
[ returning from the wilds of Kentucky... ] Stephen Frost writes: > * Craig Ringer (cr...@2ndquadrant.com) wrote: >> Personally I'd be fine with 100 or so, but when I'm using buffers side by >> side, or when I'm working in poor conditions where I've set my terminal to >>

Re: [HACKERS] Updating line length guidelines

2017-08-22 Thread Stephen Frost
Craig, all, * Craig Ringer (cr...@2ndquadrant.com) wrote: > On 21 August 2017 at 10:36, Michael Paquier > wrote: > > On Mon, Aug 21, 2017 at 11:30 AM, Robert Haas > > wrote: > > > On Sun, Aug 20, 2017 at 10:49 AM, Andres Freund

Re: [HACKERS] Updating line length guidelines

2017-08-22 Thread Alvaro Herrera
Andres Freund wrote: > We currently still have the guideline that code should fit into an 80 > character window. But an increasing amount of the code, and code > submissions, don't adhere to that (e.g. copy.c, which triggered me to > write this email). And I mean outside of accepted "exceptions"

Re: [HACKERS] Updating line length guidelines

2017-08-20 Thread Craig Ringer
On 21 August 2017 at 10:36, Michael Paquier wrote: > On Mon, Aug 21, 2017 at 11:30 AM, Robert Haas > wrote: > > On Sun, Aug 20, 2017 at 10:49 AM, Andres Freund > wrote: > >> We currently still have the guideline that code

Re: [HACKERS] Updating line length guidelines

2017-08-20 Thread Robert Haas
On Sun, Aug 20, 2017 at 10:43 PM, Andres Freund wrote: > Hm. Because you're used to it, or because more of them fit on the > screen? Both. It's also the default window size on my MacBook. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

Re: [HACKERS] Updating line length guidelines

2017-08-20 Thread Andres Freund
On 2017-08-21 11:36:43 +0900, Michael Paquier wrote: > On Mon, Aug 21, 2017 at 11:30 AM, Robert Haas wrote: > > On Sun, Aug 20, 2017 at 10:49 AM, Andres Freund wrote: > >> We currently still have the guideline that code should fit into an 80 > >>

Re: [HACKERS] Updating line length guidelines

2017-08-20 Thread Michael Paquier
On Mon, Aug 21, 2017 at 11:30 AM, Robert Haas wrote: > On Sun, Aug 20, 2017 at 10:49 AM, Andres Freund wrote: >> We currently still have the guideline that code should fit into an 80 >> character window. But an increasing amount of the code, and code >>

Re: [HACKERS] Updating line length guidelines

2017-08-20 Thread Robert Haas
On Sun, Aug 20, 2017 at 10:49 AM, Andres Freund wrote: > We currently still have the guideline that code should fit into an 80 > character window. But an increasing amount of the code, and code > submissions, don't adhere to that (e.g. copy.c, which triggered me to > write

Re: [HACKERS] Updating line length guidelines

2017-08-20 Thread Joshua D. Drake
On 08/20/2017 09:32 AM, Andres Freund wrote: On 2017-08-20 09:29:39 -0700, Joshua D. Drake wrote: On 08/20/2017 07:49 AM, Andres Freund wrote: Hi, We currently still have the guideline that code should fit into an 80 character window. But an increasing amount of the code, and code

Re: [HACKERS] Updating line length guidelines

2017-08-20 Thread Andres Freund
On 2017-08-20 09:29:39 -0700, Joshua D. Drake wrote: > On 08/20/2017 07:49 AM, Andres Freund wrote: > > Hi, > > > > We currently still have the guideline that code should fit into an 80 > > character window. But an increasing amount of the code, and code > > submissions, don't adhere to that

Re: [HACKERS] Updating line length guidelines

2017-08-20 Thread Joshua D. Drake
On 08/20/2017 07:49 AM, Andres Freund wrote: Hi, We currently still have the guideline that code should fit into an 80 character window. But an increasing amount of the code, and code submissions, don't adhere to that (e.g. copy.c, which triggered me to write this email). And I mean outside of

[HACKERS] Updating line length guidelines

2017-08-20 Thread Andres Freund
Hi, We currently still have the guideline that code should fit into an 80 character window. But an increasing amount of the code, and code submissions, don't adhere to that (e.g. copy.c, which triggered me to write this email). And I mean outside of accepted "exceptions" like error messages. And