Re: [HACKERS] Using the new libpq connection functions in PostgreSQL binaries

2010-02-02 Thread Peter Eisentraut
On sön, 2010-01-31 at 09:34 +0100, Guillaume Lelarge wrote: > I worked on a patch to make PostgreSQL binaries use the new > PQconnectdbParams() libpq functions. Can someone dig out the patch that Heikki had started to support psql automatically setting the client encoding? I think that's what sta

Re: [HACKERS] Using the new libpq connection functions in PostgreSQL binaries

2010-01-31 Thread Joe Conway
On 01/31/2010 09:42 AM, Guillaume Lelarge wrote: > I don't find that horrid. AFAICT, that's the only advantage of the > two-arrays method. By the way, it's that kind of code (keywords > declaration separated from values declaration) that got commited in the > previous patch > (http://archives.postg

Re: [HACKERS] Using the new libpq connection functions in PostgreSQL binaries

2010-01-31 Thread Guillaume Lelarge
Le 31/01/2010 17:35, Tom Lane a écrit : > Guillaume Lelarge writes: > >> */ >> do >> { >> + const char *values[] = { >> + my_opts->hostname, >> + my_opts->port, >> + my_opts->dbname, >> + my_opts->user

Re: [HACKERS] Using the new libpq connection functions in PostgreSQL binaries

2010-01-31 Thread Tom Lane
Guillaume Lelarge writes: >*/ > do > { > + const char *values[] = { > + my_opts->hostname, > + my_opts->port, > + my_opts->dbname, > + my_opts->username, > + password, > +

Re: [HACKERS] Using the new libpq connection functions in PostgreSQL binaries

2010-01-31 Thread Guillaume Lelarge
Le 31/01/2010 13:39, Magnus Hagander a écrit : > On Sun, Jan 31, 2010 at 09:34, Guillaume Lelarge > wrote: >> Hi, >> >> I worked on a patch to make PostgreSQL binaries use the new >> PQconnectdbParams() libpq functions. I tried to mimic the way Joe Conway >> changed my previous patch. >> >> I kno

Re: [HACKERS] Using the new libpq connection functions in PostgreSQL binaries

2010-01-31 Thread Magnus Hagander
On Sun, Jan 31, 2010 at 09:34, Guillaume Lelarge wrote: > Hi, > > I worked on a patch to make PostgreSQL binaries use the new > PQconnectdbParams() libpq functions. I tried to mimic the way Joe Conway > changed my previous patch. > > I know I'm way over the deadline for this commitfest. I couldn't

[HACKERS] Using the new libpq connection functions in PostgreSQL binaries

2010-01-31 Thread Guillaume Lelarge
Hi, I worked on a patch to make PostgreSQL binaries use the new PQconnectdbParams() libpq functions. I tried to mimic the way Joe Conway changed my previous patch. I know I'm way over the deadline for this commitfest. I couldn't do it before because my previous patch (on this commit fest) propose