Re: [HACKERS] V4 of PITR performance improvement for 8.4

2009-03-10 Thread Koichi Suzuki
Hi, 2009/3/10 Heikki Linnakangas : > Fujii Masao wrote: >> >> Hi, >> >> On Mon, Mar 9, 2009 at 10:20 PM, Heikki Linnakangas >> wrote: >>> >>> Thanks. This patch seems to be missing the new readahead.c file. I >>> grabbed >>> that from the previous patch version. >> >> Oh, sorry for the mistake. I

Re: [HACKERS] V4 of PITR performance improvement for 8.4

2009-03-10 Thread Heikki Linnakangas
Fujii Masao wrote: Hi, On Mon, Mar 9, 2009 at 10:20 PM, Heikki Linnakangas wrote: Thanks. This patch seems to be missing the new readahead.c file. I grabbed that from the previous patch version. Oh, sorry for the mistake. I changed one of Suzuki-san's patches to be rebased to HEAD again (rea

Re: [HACKERS] V4 of PITR performance improvement for 8.4

2009-03-09 Thread Heikki Linnakangas
Fujii Masao wrote: On Tue, Mar 3, 2009 at 1:47 PM, Fujii Masao wrote: Hi Suzuki-san, On Thu, Feb 26, 2009 at 5:03 AM, Koichi Suzuki wrote: My reply to Gregory's comment didn't have any objections. I believe, as I posted to Wiki page, latest posted patch is okay and waiting for review. One

Re: [HACKERS] V4 of PITR performance improvement for 8.4

2009-03-04 Thread Koichi Suzuki
Appreciate for your kind help! 2009/3/3 Fujii Masao : > On Tue, Mar 3, 2009 at 1:47 PM, Fujii Masao wrote: >> Hi Suzuki-san, >> >> On Thu, Feb 26, 2009 at 5:03 AM, Koichi Suzuki wrote: >>> My reply to Gregory's comment didn't have any objections.   I believe, >>> as I posted to Wiki page, latest

Re: [HACKERS] V4 of PITR performance improvement for 8.4

2009-03-02 Thread Fujii Masao
On Tue, Mar 3, 2009 at 1:47 PM, Fujii Masao wrote: > Hi Suzuki-san, > > On Thu, Feb 26, 2009 at 5:03 AM, Koichi Suzuki wrote: >> My reply to Gregory's comment didn't have any objections.   I believe, >> as I posted to Wiki page, latest posted patch is okay and waiting for >> review. > > One of yo

Re: [HACKERS] V4 of PITR performance improvement for 8.4

2009-03-02 Thread Fujii Masao
Hi Suzuki-san, On Thu, Feb 26, 2009 at 5:03 AM, Koichi Suzuki wrote: > My reply to Gregory's comment didn't have any objections.   I believe, > as I posted to Wiki page, latest posted patch is okay and waiting for > review. One of your latest patches doesn't match with HEAD, so I updated it. Re

Re: [HACKERS] V4 of PITR performance improvement for 8.4

2009-02-25 Thread Koichi Suzuki
Hi, My reply to Gregory's comment didn't have any objections. I believe, as I posted to Wiki page, latest posted patch is okay and waiting for review. 2009/2/24 Robert Haas : > On Sun, Jan 25, 2009 at 7:15 AM, Gregory Stark wrote: >> Koichi Suzuki writes: >> >>> Please find enclosed 2nd patch

Re: [HACKERS] V4 of PITR performance improvement for 8.4

2009-02-24 Thread Robert Haas
On Sun, Jan 25, 2009 at 7:15 AM, Gregory Stark wrote: > Koichi Suzuki writes: > >> Please find enclosed 2nd patch of pg_readahead which include a patch >> to bufer manager to skip prefetch of pages already in shared buffer. > > I'm a bit confused by this comment. PrefetchBuffer already checks if

Re: [HACKERS] V4 of PITR performance improvement for 8.4

2009-01-28 Thread Koichi Suzuki
Hi, This is also a reply to your latest post.I'm replying to the older one because I need original text. 2009/1/26 Koichi Suzuki : > Hi, > > It's simply because we should not refer to system catalog during the recovery. This is the reason why I didn't use PrefetchBuffer(). Prefetch buffer

Re: [HACKERS] V4 of PITR performance improvement for 8.4

2009-01-26 Thread Gregory Stark
Koichi Suzuki writes: > It's simply because we should not refer to system catalog during the recovery. I don't understand how this is connected to anything to do with prefetching? -- Gregory Stark EnterpriseDB http://www.enterprisedb.com Ask me about EnterpriseDB's On-Demand P

Re: [HACKERS] V4 of PITR performance improvement for 8.4

2009-01-25 Thread Koichi Suzuki
Hi, It's simply because we should not refer to system catalog during the recovery. 2009/1/25 Gregory Stark : > > Koichi Suzuki writes: > >> Please find enclosed 2nd patch of pg_readahead which include a patch >> to bufer manager to skip prefetch of pages already in shared buffer. > > I'm a bit c

Re: [HACKERS] V4 of PITR performance improvement for 8.4

2009-01-25 Thread Gregory Stark
Koichi Suzuki writes: > Please find enclosed 2nd patch of pg_readahead which include a patch > to bufer manager to skip prefetch of pages already in shared buffer. I'm a bit confused by this comment. PrefetchBuffer already checks if the page is in shared buffers. What is tricky to avoid is pr

Re: [HACKERS] V4 of PITR performance improvement for 8.4

2009-01-13 Thread ITAGAKI Takahiro
"Koichi Suzuki" wrote: > > This patc also include additional patch for posix_fadvise to skip > > prefetch of pages which does not exist. I reviewed your patch and found items to be fixed and improved. - You should not claim your copyrights. There are your copyright claims in two files newly ad

Re: [HACKERS] V4 of PITR performance improvement for 8.4

2009-01-13 Thread Koichi Suzuki
Sorry, I didn't attatch the patch file. This is the second try. 2009/1/12 Koichi Suzuki : > This is V4 patch to improve file read during startup for review. > > Basic algorithm is same as V3 but works with Gregory's fadvise patch. > > http://archives.postgresql.org/pgsql-hackers/2009-01/msg00026.

[HACKERS] V4 of PITR performance improvement for 8.4

2009-01-12 Thread Koichi Suzuki
This is V4 patch to improve file read during startup for review. Basic algorithm is same as V3 but works with Gregory's fadvise patch. http://archives.postgresql.org/pgsql-hackers/2009-01/msg00026.php This patc also include additional patch for posix_fadvise to skip prefetch of pages which does