Re: [HACKERS] VACUUM messages without newlines

2010-06-01 Thread Tom Lane
Thom Brown writes: > Yes, I can see that now. I'd looked up other messages which appear in > the log and noticed they were terminated with newlines in the > back-end, but I guess those were of a different type and happen to > share the same output. Hm, sure you're not thinking of frontend code?

Re: [HACKERS] VACUUM messages without newlines

2010-06-01 Thread Alvaro Herrera
Excerpts from Thom Brown's message of mar jun 01 11:34:38 -0400 2010: > On 1 June 2010 16:28, Alvaro Herrera wrote: > > The message pieces are sent separately.  They are only crammed in a > > single line if the interface is using the old mechanism to extract error > > message info; anything built

Re: [HACKERS] VACUUM messages without newlines

2010-06-01 Thread Thom Brown
On 1 June 2010 16:50, Tom Lane wrote: > Thom Brown writes: >> I see what you mean.  I'm seeing this in the latest version of pgAdmin >> III (1.10.3) so looks like it's not up-to-date in that respect. >> Should report it as a pgAdmin problem then? > > Yes.  The message texts in ereport() calls are

Re: [HACKERS] VACUUM messages without newlines

2010-06-01 Thread Tom Lane
Thom Brown writes: > I see what you mean. I'm seeing this in the latest version of pgAdmin > III (1.10.3) so looks like it's not up-to-date in that respect. > Should report it as a pgAdmin problem then? Yes. The message texts in ereport() calls are *not* supposed to have trailing newlines. If

Re: [HACKERS] VACUUM messages without newlines

2010-06-01 Thread Thom Brown
On 1 June 2010 16:28, Alvaro Herrera wrote: > Excerpts from Thom Brown's message of mar jun 01 11:16:33 -0400 2010: >> This has annoyed me for some time, but it appears that in the VACUUM >> log, the line which says... >> >> INFO: analyzing "%s.%s" >> >> ...( and appears in pgsql/src/backend/comma

Re: [HACKERS] VACUUM messages without newlines

2010-06-01 Thread Alvaro Herrera
Excerpts from Thom Brown's message of mar jun 01 11:16:33 -0400 2010: > This has annoyed me for some time, but it appears that in the VACUUM > log, the line which says... > > INFO: analyzing "%s.%s" > > ...( and appears in pgsql/src/backend/commands/analyze.c lines 282 and > 287 ) doesn't termin

[HACKERS] VACUUM messages without newlines

2010-06-01 Thread Thom Brown
This has annoyed me for some time, but it appears that in the VACUUM log, the line which says... INFO: analyzing "%s.%s" ...( and appears in pgsql/src/backend/commands/analyze.c lines 282 and 287 ) doesn't terminate with a newline, meaning the next message appears immediately after it. Either t