Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote:
We can remove the complexity if we give up showing the command (arg0)
in error messages. Shall we remove it? Simplified patch attached.
Here is the proposal for the arg0 issue.
I added context argument to putVariable(). The context is a
On Mon, Jan 4, 2010 at 10:00 PM, Takahiro Itagaki
itagaki.takah...@oss.ntt.co.jp wrote:
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote:
We can remove the complexity if we give up showing the command (arg0)
in error messages. Shall we remove it? Simplified patch attached.
Here is the
Robert Haas robertmh...@gmail.com wrote:
What is currently done for other, similar error messages?
Current error messages are:
for commands: context: out of memory
for others : Couldn't allocate memory for variable
The new message is: context: out of memory for variable 'name'
Regards,
On Mon, Jan 4, 2010 at 10:44 PM, Takahiro Itagaki
itagaki.takah...@oss.ntt.co.jp wrote:
Robert Haas robertmh...@gmail.com wrote:
What is currently done for other, similar error messages?
Current error messages are:
for commands: context: out of memory
for others : Couldn't allocate
Robert Haas robertmh...@gmail.com wrote:
The attached patch verifies variable names at definition.
$ pgbench -D var:name=value
(global): invalid variable name 'var:name'
I have reviewed this patch. I think that the basic idea of rejecting
invalid variable names is probably a
We can define variables with any names in pgbench,
but only can refer them with names that consist of [A-Za-z0-9_]+ .
It could cause confusion discussed here:
http://archives.postgresql.org/message-id/4b272833.8080...@2ndquadrant.com
The attached patch verifies variable names at definition.
$
