Re: [HACKERS] Visual Studio 2012 RC

2013-02-05 Thread Andrew Dunstan
On 02/01/2013 08:55 AM, Andrew Dunstan wrote: On 02/01/2013 06:12 AM, Craig Ringer wrote: On 01/26/2013 10:56 PM, Noah Misch wrote: On Sat, Jan 26, 2013 at 12:20:56PM +0800, Craig Ringer wrote: Just to confirm, I think that this is ready for commit as posted in

Re: [HACKERS] Visual Studio 2012 RC

2013-02-05 Thread Magnus Hagander
On Feb 5, 2013 5:34 PM, Andrew Dunstan and...@dunslane.net wrote: On 02/01/2013 08:55 AM, Andrew Dunstan wrote: On 02/01/2013 06:12 AM, Craig Ringer wrote: On 01/26/2013 10:56 PM, Noah Misch wrote: On Sat, Jan 26, 2013 at 12:20:56PM +0800, Craig Ringer wrote: Just to confirm, I think

Re: [HACKERS] Visual Studio 2012 RC

2013-02-05 Thread Noah Misch
On Tue, Feb 05, 2013 at 11:34:26AM -0500, Andrew Dunstan wrote: OK, I have looked at this and it seems perfectly sane. In fact, after a very frustrating time VS2012 is the *only* way I have found to get a 64 bit build using MS tools on Windows 8. Given that, I propose to backport these

Re: [HACKERS] Visual Studio 2012 RC

2013-02-01 Thread Craig Ringer
On 01/26/2013 10:56 PM, Noah Misch wrote: On Sat, Jan 26, 2013 at 12:20:56PM +0800, Craig Ringer wrote: Just to confirm, I think that this is ready for commit as posted in 20130101025421.ga17...@tornado.leadboat.com. I'll amend my docs changes and submit them separately. Thanks. Here's a

Re: [HACKERS] Visual Studio 2012 RC

2013-02-01 Thread Andrew Dunstan
On 02/01/2013 06:12 AM, Craig Ringer wrote: On 01/26/2013 10:56 PM, Noah Misch wrote: On Sat, Jan 26, 2013 at 12:20:56PM +0800, Craig Ringer wrote: Just to confirm, I think that this is ready for commit as posted in 20130101025421.ga17...@tornado.leadboat.com. I'll amend my docs changes and

Re: [HACKERS] Visual Studio 2012 RC

2013-01-27 Thread james
Anyway, this is getting way off track. The point is that the MS SDKs and compilers are a bit of a mess and that MinGW support is useful because we can't rely on them continuing to offer free SDKs and compilers in future. Well, more compilers are always useful, but complaining that Microsoft

Re: [HACKERS] Visual Studio 2012 RC

2013-01-27 Thread Andrew Dunstan
On 01/27/2013 02:48 PM, james wrote: Anyway, this is getting way off track. The point is that the MS SDKs and compilers are a bit of a mess and that MinGW support is useful because we can't rely on them continuing to offer free SDKs and compilers in future. Well, more compilers are always

Re: [HACKERS] Visual Studio 2012 RC

2013-01-27 Thread james
On the contrary, only a few months ago there was a far from groundless fear that Microsoft would do just that. Following considerable outcry they changed their mind. But this is definitely not just paranoia. As for w64 support, the mingw-64 project exists more or less explicitly to produce 64

Re: [HACKERS] Visual Studio 2012 RC

2013-01-27 Thread Andrew Dunstan
On 01/27/2013 06:51 PM, james wrote: On the contrary, only a few months ago there was a far from groundless fear that Microsoft would do just that. Following considerable outcry they changed their mind. But this is definitely not just paranoia. As for w64 support, the mingw-64 project exists

Re: [HACKERS] Visual Studio 2012 RC

2013-01-26 Thread Noah Misch
On Sat, Jan 26, 2013 at 12:20:56PM +0800, Craig Ringer wrote: On 01/24/2013 01:13 PM, Craig Ringer wrote: On 01/24/2013 11:28 AM, Craig Ringer wrote: On 01/24/2013 09:38 AM, Noah Misch wrote: The most notable difference is that I have no pre-VS2012 Microsoft compilers installed and no

Re: [HACKERS] Visual Studio 2012 RC

2013-01-26 Thread Craig Ringer
On 01/26/2013 03:39 PM, Andrew Dunstan wrote: On 01/26/2013 12:38 AM, Craig Ringer wrote: On 01/25/2013 08:25 PM, Noah Misch wrote: That should be clearer, that 64-bit support exists but is absent (AFAIK) from Express editions. Build farm member chough builds 64-bit using VS 2008 Express.

Re: [HACKERS] Visual Studio 2012 RC

2013-01-26 Thread Craig Ringer
On 01/27/2013 08:11 AM, Craig Ringer wrote: On my VS Express 2010 SP1: Setting environment for using Microsoft Visual Studio 2010 x86 tools. C:\Program Files (x86)\Microsoft Visual Studio 10.0\VCvcvarsall.bat /? Error in script usage. The correct usage is: vcvarsall.bat [option]

Re: [HACKERS] Visual Studio 2012 RC

2013-01-25 Thread Noah Misch
On Fri, Jan 25, 2013 at 11:20:56AM +0800, Craig Ringer wrote: On 01/25/2013 11:09 AM, Noah Misch wrote: The official 9.0 and 9.1 64-bit builds are made with VS 2008, and the 9.2 builds with VS 2010. Paid versions, though, right? So I hear. That should be clearer, that 64-bit support

Re: [HACKERS] Visual Studio 2012 RC

2013-01-25 Thread Craig Ringer
On 01/24/2013 01:13 PM, Craig Ringer wrote: On 01/24/2013 11:28 AM, Craig Ringer wrote: On 01/24/2013 09:38 AM, Noah Misch wrote: The most notable difference is that I have no pre-VS2012 Microsoft compilers installed and no SDKs installed by my explicit action. I suggest assessing how the

Re: [HACKERS] Visual Studio 2012 RC

2013-01-25 Thread Craig Ringer
On 01/25/2013 08:25 PM, Noah Misch wrote: That should be clearer, that 64-bit support exists but is absent (AFAIK) from Express editions. Build farm member chough builds 64-bit using VS 2008 Express. Huh. My 2008 doesn't appear to have 64-bit compilers or cross-compilers and didn't offer them

Re: [HACKERS] Visual Studio 2012 RC

2013-01-25 Thread Andrew Dunstan
On 01/26/2013 12:38 AM, Craig Ringer wrote: On 01/25/2013 08:25 PM, Noah Misch wrote: That should be clearer, that 64-bit support exists but is absent (AFAIK) from Express editions. Build farm member chough builds 64-bit using VS 2008 Express. Huh. My 2008 doesn't appear to have 64-bit

Re: [HACKERS] Visual Studio 2012 RC

2013-01-24 Thread Noah Misch
On Thu, Jan 24, 2013 at 01:13:33PM +0800, Craig Ringer wrote: I have some final revisions to propose for the documentation but otherwise this looks ready for commit. These documentation changes are barely connected to the addition of VS 2012 support, so I think they should remain separate. !

Re: [HACKERS] Visual Studio 2012 RC

2013-01-24 Thread Craig Ringer
On 01/25/2013 11:09 AM, Noah Misch wrote: On Thu, Jan 24, 2013 at 01:13:33PM +0800, Craig Ringer wrote: I have some final revisions to propose for the documentation but otherwise this looks ready for commit. These documentation changes are barely connected to the addition of VS 2012 support,

Re: [HACKERS] Visual Studio 2012 RC

2013-01-23 Thread Brar Piening
On 01/23/2013 02:14 PM, Craig Ringer wrote: How have you been testing VS2012 builds? In what environment? When I tested this patch the last time I've been using Windows 8 RTM (Microsoft Windows 8 Enterprise Evaluation - 6.2.9200 Build 9200) and Microsoft Visual Studio Express 2012 für

Re: [HACKERS] Visual Studio 2012 RC

2013-01-23 Thread Craig Ringer
On 01/24/2013 03:23 AM, Brar Piening wrote: On 01/23/2013 02:14 PM, Craig Ringer wrote: How have you been testing VS2012 builds? In what environment? When I tested this patch the last time I've been using Windows 8 RTM (Microsoft Windows 8 Enterprise Evaluation - 6.2.9200 Build 9200) and

Re: [HACKERS] Visual Studio 2012 RC

2013-01-23 Thread Noah Misch
Hi Craig, Thanks for testing. On Wed, Jan 23, 2013 at 02:55:55PM +0800, Craig Ringer wrote: When building a tree with your patch applied using VS 2012 Express via a command line environment set up with: c:\program files (x86)\Microsoft Visual Studio 11.0\VC\vcvarsall.bat x86 Likewise.

Re: [HACKERS] Visual Studio 2012 RC

2013-01-23 Thread Craig Ringer
On 01/24/2013 09:38 AM, Noah Misch wrote: The most notable difference is that I have no pre-VS2012 Microsoft compilers installed and no SDKs installed by my explicit action. I suggest assessing how the Framework64 directories get into your path and trying without them. nm Interesting. The

Re: [HACKERS] Visual Studio 2012 RC

2013-01-23 Thread Craig Ringer
On 01/24/2013 09:38 AM, Noah Misch wrote: The most notable difference is that I have no pre-VS2012 Microsoft compilers installed and no SDKs installed by my explicit action. I suggest assessing how the Framework64 directories get into your path and trying without them. nm A further update on

Re: [HACKERS] Visual Studio 2012 RC

2013-01-23 Thread Craig Ringer
On 01/24/2013 11:28 AM, Craig Ringer wrote: On 01/24/2013 09:38 AM, Noah Misch wrote: The most notable difference is that I have no pre-VS2012 Microsoft compilers installed and no SDKs installed by my explicit action. I suggest assessing how the Framework64 directories get into your path and

Re: [HACKERS] Visual Studio 2012 RC

2013-01-22 Thread Craig Ringer
On 01/21/2013 09:06 PM, Craig Ringer wrote: It's building on my Jenkins instance at the moment, to make sure it doesn't break VS 2010 / Windows SDK 7.1 . I've merged it into HEAD and pushed to https://github.com/ringerc/postgres/tree/vs2012; the only conflict was a trivial one in the docs. A

Re: [HACKERS] Visual Studio 2012 RC

2013-01-22 Thread Craig Ringer
On 01/23/2013 02:14 PM, Craig Ringer wrote: On 01/21/2013 09:06 PM, Craig Ringer wrote: It's building on my Jenkins instance at the moment, to make sure it doesn't break VS 2010 / Windows SDK 7.1 . I've merged it into HEAD and pushed to https://github.com/ringerc/postgres/tree/vs2012; the

Re: [HACKERS] Visual Studio 2012 RC

2013-01-21 Thread Craig Ringer
On 01/01/2013 10:54 AM, Noah Misch wrote: On Mon, Oct 15, 2012 at 07:53:51AM -0400, Noah Misch wrote: The only matter still requiring attention is a fix for IsoLocaleName(). Following off-list coordination with Brar, I went about finishing up this patch. The above problem proved deeper than

Re: [HACKERS] Visual Studio 2012 RC

2013-01-21 Thread Noah Misch
On Mon, Jan 21, 2013 at 05:32:37PM +0800, Craig Ringer wrote: On 01/01/2013 10:54 AM, Noah Misch wrote: Tester warning: if you currently have some form of VS2010 installed, including the compilers of Windows SDK 7.1, beware of this problem:

Re: [HACKERS] Visual Studio 2012 RC

2013-01-21 Thread Craig Ringer
On 01/21/2013 07:23 PM, Noah Misch wrote: What fun. Thanks for working that out. It's made even more fun by Microsoft's answer to how do I silent-install the VS 2012 SP1 compiler update - you don't. Yeah, it's great. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] Visual Studio 2012 RC

2013-01-21 Thread Andrew Dunstan
On 01/21/2013 04:32 AM, Craig Ringer wrote: On 01/01/2013 10:54 AM, Noah Misch wrote: On Mon, Oct 15, 2012 at 07:53:51AM -0400, Noah Misch wrote: The only matter still requiring attention is a fix for IsoLocaleName(). Following off-list coordination with Brar, I went about finishing up this

Re: [HACKERS] Visual Studio 2012 RC

2013-01-21 Thread Craig Ringer
On 01/21/2013 08:44 PM, Andrew Dunstan wrote: On 01/21/2013 04:32 AM, Craig Ringer wrote: On 01/01/2013 10:54 AM, Noah Misch wrote: On Mon, Oct 15, 2012 at 07:53:51AM -0400, Noah Misch wrote: The only matter still requiring attention is a fix for IsoLocaleName(). Following off-list

Re: [HACKERS] Visual Studio 2012 RC

2012-12-31 Thread Noah Misch
On Mon, Oct 15, 2012 at 07:53:51AM -0400, Noah Misch wrote: The only matter still requiring attention is a fix for IsoLocaleName(). Following off-list coordination with Brar, I went about finishing up this patch. The above problem proved deeper than expected. For Windows Vista, Microsoft made

Re: [HACKERS] Visual Studio 2012 RC

2012-10-24 Thread Brar Piening
Alvaro Herrera wrote: There having been no updated patch yet, I have closed this as returned with feedback. Thanks Noah! Please make sure to submit an updated patch to the upcoming commitfest, which is due to start in about three weeks. Due to an hyperacute increase of workload in my day

Re: [HACKERS] Visual Studio 2012 RC

2012-10-23 Thread Alvaro Herrera
Noah Misch wrote: On Mon, Oct 15, 2012 at 09:17:09PM +0200, Brar Piening wrote: Noah Misch wrote: The only matter still requiring attention is a fix for IsoLocaleName(). Yep - I'll work on this and on some denoisifying of the build log files. Great. Just to be clear, I consider the

Re: [HACKERS] Visual Studio 2012 RC

2012-10-15 Thread Noah Misch
On Sun, Oct 14, 2012 at 11:13:46PM +0200, Brar Piening wrote: Noah Misch wrote: Since SDK version 7.1 is named as the latest supported version, I understand from that text that installing SDK version 8.0a along with compilers from another source (VS 2012 full, VS 2012 Express for Desktop) is

Re: [HACKERS] Visual Studio 2012 RC

2012-10-15 Thread Brar Piening
Noah Misch wrote: The only matter still requiring attention is a fix for IsoLocaleName(). Yep - I'll work on this and on some denoisifying of the build log files. Regards, Brar -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Visual Studio 2012 RC

2012-10-15 Thread Noah Misch
On Mon, Oct 15, 2012 at 09:17:09PM +0200, Brar Piening wrote: Noah Misch wrote: The only matter still requiring attention is a fix for IsoLocaleName(). Yep - I'll work on this and on some denoisifying of the build log files. Great. Just to be clear, I consider the denoisification optional.

Re: [HACKERS] Visual Studio 2012 RC

2012-10-14 Thread Brar Piening
Noah Misch wrote: My build log filled 8.8 MiB, a large increase from the 432 KiB of the chough build log. This isn't strictly a problem, but do you happen to have ideas for curbing the noise? Not yet. I find no functional problems with the patch, but some comment updates and other trivia

Re: [HACKERS] Visual Studio 2012 RC

2012-10-14 Thread Brar Piening
Noah Misch wrote: I decided to try a 32-bit build, but Solution::DeterminePlatform detected it as x64. Its shibboleth is no longer valid; the cl.exe shipping with VS 2012 Express for Desktop has a /favor option for both architectures: 32clhelp:/favor:blend|ATOM select processor to optimize

Re: [HACKERS] Visual Studio 2012 RC

2012-10-08 Thread Noah Misch
On Sun, Oct 07, 2012 at 08:30:22PM +0200, Brar Piening wrote: Noah Misch wrote: I'm marking this patch Waiting on Author, but the changes needed to get it Ready for Committer are fairly trivial. Thanks, nm Thanks for your review and sorry for my delayed response - I've been on vacation.

Re: [HACKERS] Visual Studio 2012 RC

2012-10-08 Thread Noah Misch
One more thing -- I tried a build with NLS support and encountered this: src\backend\utils\adt\pg_locale.c(746): error C2039: 'lc_handle' : is not a member of 'threadlocaleinfostruct' [c:\cygwin\home\nm\src\pg\postgresql\postgres.vcxproj] That's in the function IsoLocaleName(), which digs

Re: [HACKERS] Visual Studio 2012 RC

2012-10-07 Thread Brar Piening
Noah Misch wrote: I'm marking this patch Waiting on Author, but the changes needed to get it Ready for Committer are fairly trivial. Thanks, nm Thanks for your review and sorry for my delayed response - I've been on vacation. I'll look into adressing your comments and suggestions within

Re: [HACKERS] Visual Studio 2012 RC

2012-10-02 Thread Noah Misch
On Fri, Sep 14, 2012 at 01:26:30AM +0200, Brar Piening wrote: Heikki Linnakangas wrote: I don't think we can realistically support VS2012 until Microsoft releases the gratis Visual Studio Express 2012 for Windows Desktop. As they've released now I've updated my Patch with docs and ask for

Re: [HACKERS] Visual Studio 2012 RC

2012-09-13 Thread Brar Piening
Heikki Linnakangas wrote: I don't think we can realistically support VS2012 until Microsoft releases the gratis Visual Studio Express 2012 for Windows Desktop. As they've released now I've updated my Patch with docs and ask for review. Regards, Brar diff -Napcdr -x .git

Re: [HACKERS] Visual Studio 2012 RC

2012-06-27 Thread Heikki Linnakangas
On 10.06.2012 11:41, Magnus Hagander wrote: On Sun, Jun 10, 2012 at 3:16 AM, Brar Pieningb...@gmx.de wrote: Magnus Hagander wrote: I don't have too much hope for them actually changing it - they seem hell-bent on forcing everybody into metro, and this seems to be yet another way to do that.

Re: [HACKERS] Visual Studio 2012 RC

2012-06-10 Thread Dave Page
On Sunday, June 10, 2012, Brar Piening wrote: Magnus Hagander wrote: I don't have too much hope for them actually changing it - they seem hell-bent on forcing everybody into metro, and this seems to be yet another way to do that. But we can always hope... Looks like they've learnt their

Re: [HACKERS] Visual Studio 2012 RC

2012-06-10 Thread Magnus Hagander
On Sun, Jun 10, 2012 at 3:16 AM, Brar Piening b...@gmx.de wrote: Magnus Hagander wrote: I don't have too much hope for them actually changing it - they seem hell-bent on forcing everybody into metro, and this seems to be yet another way to do that. But we can always hope... Looks like

Re: [HACKERS] Visual Studio 2012 RC

2012-06-09 Thread Brar Piening
Magnus Hagander wrote: I don't have too much hope for them actually changing it - they seem hell-bent on forcing everybody into metro, and this seems to be yet another way to do that. But we can always hope... Looks like they've learnt their lesson...

Re: [HACKERS] Visual Studio 2012 RC

2012-06-03 Thread Magnus Hagander
On Sat, Jun 2, 2012 at 11:26 PM, Brar Piening b...@gmx.de wrote: The attached patch makes postgres build with Visual Studio 2012 RC. Looks good in principle - please add it to the next commitfest (https://commitfest.postgresql.org/action/commitfest_view?id=14). We're definitely not adding a new

Re: [HACKERS] Visual Studio 2012 RC

2012-06-03 Thread Dave Page
On Sun, Jun 3, 2012 at 11:22 AM, Magnus Hagander mag...@hagander.net wrote: On Sat, Jun 2, 2012 at 11:26 PM, Brar Piening b...@gmx.de wrote: The attached patch makes postgres build with Visual Studio 2012 RC. Looks good in principle - please add it to the next commitfest

Re: [HACKERS] Visual Studio 2012 RC

2012-06-03 Thread Magnus Hagander
On Sun, Jun 3, 2012 at 12:37 PM, Dave Page dp...@pgadmin.org wrote: On Sun, Jun 3, 2012 at 11:22 AM, Magnus Hagander mag...@hagander.net wrote: On Sat, Jun 2, 2012 at 11:26 PM, Brar Piening b...@gmx.de wrote: The attached patch makes postgres build with Visual Studio 2012 RC. Looks good in

Re: [HACKERS] Visual Studio 2012 RC

2012-06-03 Thread Dave Page
On Sun, Jun 3, 2012 at 11:38 AM, Magnus Hagander mag...@hagander.net wrote: We might also want to think twice about producing the installers with 2012, and just stick to 2010 pro for that. Because once we go 2012 on that, it's no longer going ot be possible to build addons without either

[HACKERS] Visual Studio 2012 RC

2012-06-02 Thread Brar Piening
The attached patch makes postgres build with Visual Studio 2012 RC. As MS finally decided on the name I don't expect any need for changes for the final RTM. I didn't bother to update the docs for now as I still have some hope that the developer community succeds in pushig M$ to reverse this