Re: [PATCHES] [HACKERS] WAL: O_DIRECT and multipage-writer (+

2005-06-04 Thread Bruce Momjian
Yes, I assume that the patch to group the writes isn't something we want right now, and the one for O_DIRECT is going to need an additional fsync, and I have asked for testing on that. I have posted a patch that I think fixes the memory leak reported and am waiting for feedback on that.

Re: [HACKERS] WAL: O_DIRECT and multipage-writer

2005-03-23 Thread Mark Wong
On Wed, Mar 23, 2005 at 01:55:46PM +0900, ITAGAKI Takahiro wrote: Hi, Mark. Mark Wong [EMAIL PROTECTED] wrote: In light of this thread, have you compared the performance on Linux-2.4? No, but I'm just testing my patch on Linux-2.4 with a middle-range server. I will report the results

Re: [HACKERS] WAL: O_DIRECT and multipage-writer

2005-03-22 Thread Mark Wong
On Tue, Jan 25, 2005 at 06:06:23PM +0900, ITAGAKI Takahiro wrote: Environment: OS : Linux kernel 2.6.9 CPU: Pentium 4 3GHz disk : ATA 5400rpm (Data and WAL are placed on same partition.) memory : 1GB config : shared_buffers=1, wal_buffers=256,

Re: [HACKERS] WAL: O_DIRECT and multipage-writer

2005-03-22 Thread ITAGAKI Takahiro
Hi, Mark. Mark Wong [EMAIL PROTECTED] wrote: In light of this thread, have you compared the performance on Linux-2.4? No, but I'm just testing my patch on Linux-2.4 with a middle-range server. I will report the results sometime soon. By the way, I found the debug option

Re: [PATCHES] [HACKERS] WAL: O_DIRECT and multipage-writer (+

2005-03-11 Thread Simon Riggs
On Tue, 2005-03-01 at 13:53 -0800, Mark Wong wrote: On Thu, Feb 03, 2005 at 07:25:55PM +0900, ITAGAKI Takahiro wrote: Hello everyone. I fixed two bugs in the patch that I sent before. Check and test new one, please. Ok, finally got back into the office and was able to run 1 set of

Re: [PATCHES] [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory leak)

2005-03-01 Thread Mark Wong
On Thu, Feb 03, 2005 at 07:25:55PM +0900, ITAGAKI Takahiro wrote: Hello everyone. I fixed two bugs in the patch that I sent before. Check and test new one, please. Ok, finally got back into the office and was able to run 1 set of tests. So the new baseline result with 8.0.1:

Re: [HACKERS] WAL: O_DIRECT and multipage-writer

2005-02-14 Thread Bruce Momjian
This thread has been saved for the 8.1 release: http://momjian.postgresql.org/cgi-bin/pgpatches2 --- ITAGAKI Takahiro wrote: Hello, all. I think that there is room for improvement in WAL. Here is a patch for

Re: [PATCHES] [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory

2005-02-14 Thread Bruce Momjian
This has been saved for the 8.1 release: http://momjian.postgresql.org/cgi-bin/pgpatches2 --- ITAGAKI Takahiro wrote: Hello everyone. I fixed two bugs in the patch that I sent before. Check and test new one,

Re: [PATCHES] [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory leak)

2005-02-03 Thread ITAGAKI Takahiro
Hello everyone. I fixed two bugs in the patch that I sent before. Check and test new one, please. 1. Fix update timing of Write-curridx. (pointed by Tom) Change to update it soon after write(). 2. Fix buffer alignment routine on 64bit cpu. (pointed by Mark) I checked it on Xeon EM64T

Re: [HACKERS] WAL: O_DIRECT and multipage-writer

2005-01-27 Thread Mark Wong
Hi everyone, I gave this a try with DBT-2, but got a core dump on our ia64 system. I hope this isn't a random thing, like I ran into previously. Maybe I'll try again, but postgres dumped core. Binary and core here: http://developer.osdl.org/markw/pgsql/core/2morefiles.tar.bz2 #0

Re: [PATCHES] [HACKERS] WAL: O_DIRECT and multipage-writer

2005-01-27 Thread ITAGAKI Takahiro
Thanks for testing, Mark! I gave this a try with DBT-2, but got a core dump on our ia64 system. I hope this isn't a random thing, like I ran into previously. Maybe I'll try again, but postgres dumped core. Sorry, this seems to be my patch's bug. Which datatype did you compile with? LP64,

Re: [PATCHES] [HACKERS] WAL: O_DIRECT and multipage-writer

2005-01-27 Thread Mark Wong
Hmm... I don't remember specifying a datatype. I suppose whatever the default one is. :) I'll be happy to test again, just let me know. Mark On Fri, Jan 28, 2005 at 06:28:32AM +0900, ITAGAKI Takahiro wrote: Thanks for testing, Mark! I gave this a try with DBT-2, but got a core dump on our

Re: [HACKERS] WAL: O_DIRECT and multipage-writer

2005-01-26 Thread ITAGAKI Takahiro
Tom Lane [EMAIL PROTECTED] writes: What does XLOG_EXTRA_BUFFERS accomplish? It is because the buffer passed to direct-io must be aligned to the same size of filesystem page, typically 4KB. Buffers allocated with ShmemInitStruct are not necessarily aligned, so we need to allocate extra buffers

[HACKERS] WAL: O_DIRECT and multipage-writer

2005-01-25 Thread ITAGAKI Takahiro
Hello, all. I think that there is room for improvement in WAL. Here is a patch for it. - Multiple pages are written in one write() if it is contiguous. - Add 'open_direct' to wal_sync_method. WAL writer writes one page in one write(). This is not efficient when wal_sync_method is