Re: [HACKERS] WIP: log query in auto-explain

2009-11-23 Thread Itagaki Takahiro
Andrew Dunstan and...@dunslane.net wrote: Basically it includes the text of the query being explained in the explain output. I expected the query text is printed in STATEMENT section. Do you mean the query should be merged into LOG section? Are there any situation where STATEMENT section

Re: [HACKERS] WIP: log query in auto-explain

2009-11-23 Thread Andrew Dunstan
Itagaki Takahiro wrote: Andrew Dunstan and...@dunslane.net wrote: Basically it includes the text of the query being explained in the explain output. I expected the query text is printed in STATEMENT section. Do you mean the query should be merged into LOG section? Are there any

Re: [HACKERS] WIP: log query in auto-explain

2009-11-23 Thread Itagaki Takahiro
Andrew Dunstan and...@dunslane.net wrote: I mean it should be in the Explain output: explain xmlns=http://www.postgresql.org/2009/explain; Query-TextSELECT '' AS zero, BOOLTBL1.* A number of users (including me) badly want to be able to extract the explain output from the log

[HACKERS] WIP: log query in auto-explain

2009-11-22 Thread Andrew Dunstan
I put the attached together a while ago and neglected to send it. Basically it includes the text of the query being explained in the explain output. I think it's more important to include the query text when using auto_explain than in other explain uses, which is why I did it this way. But

Re: [HACKERS] WIP: log query in auto-explain

2009-11-22 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: I put the attached together a while ago and neglected to send it. Basically it includes the text of the query being explained in the explain output. I'm pretty certain this will dump core in some contexts --- you should not assume that sourceText is

Re: [HACKERS] WIP: log query in auto-explain

2009-11-22 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: I put the attached together a while ago and neglected to send it. Basically it includes the text of the query being explained in the explain output. I'm pretty certain this will dump core in some contexts --- you should not