Re: [HACKERS] WIP Patch: Precalculate stable functions, infrastructure v1

The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested Hi Marina, I'm sorry to inform you that the v5 path set become a little

Re: [HACKERS] WIP Patch: Precalculate stable functions, infrastructure v1

Like for the previous patches it seems that there is no obvious performance degradation too on regular queries (according to pgbench). pgbench probably isn't a very good test for this sort of thing - it only issues very short-running queries where the cost of evaluating expressions is a

Re: [HACKERS] WIP Patch: Precalculate stable functions, infrastructure v1

On Tue, Jul 18, 2017 at 9:16 AM, Marina Polyakova wrote: > Here I have made the 5th version of the patches. I have added the > precalculation of all primitive nodes that don't return set, are not > volatile themselves and their arguments are constant or precalculated >

Re: [HACKERS] WIP Patch: Precalculate stable functions, infrastructure v1

Hi Marina, Hello again! I still don't see anything particularly wrong with your patch. It applies, passes all test, it is well test-covered and even documented. Also I've run `make installcheck` under Valgrind and didn't find any memory-related errors. Thank you very much as usual! Is

Re: [HACKERS] WIP Patch: Precalculate stable functions, infrastructure v1

Hi Marina, I still don't see anything particularly wrong with your patch. It applies, passes all test, it is well test-covered and even documented. Also I've run `make installcheck` under Valgrind and didn't find any memory-related errors. Is there anything that you would like to change before

Re: [HACKERS] WIP Patch: Precalculate stable functions, infrastructure v1

Hi, On 2017-05-18 19:00:09 +0300, Marina Polyakova wrote: > > Here's v2 of the patches. Changes from v1: > > And here there's v3 of planning and execution: common executor steps for all > types of cached expression. I've not followed this thread, but just scanned this quickly because it

Re: [HACKERS] WIP Patch: Precalculate stable functions, infrastructure v1

Here's v2 of the patches. Changes from v1: And here there's v3 of planning and execution: common executor steps for all types of cached expression. -- Marina Polyakova Postgres Professional: http://www.postgrespro.com The Russian Postgres CompanyFrom 5e89221251670526eb2b5750868ac73eee48f10b

Re: [HACKERS] WIP Patch: Precalculate stable functions, infrastructure v1

Hello, Aleksander! I've noticed that this patch needs a review and decided to take a look. Thank you very much! There are a trailing whitespaces, though. Oh, sorry, I'll check them. I see 8-10% performance improvement on full text search queries. Glad to hear it =) It seems that

Re: [HACKERS] WIP Patch: Precalculate stable functions, infrastructure v1

Hi Marina, I've noticed that this patch needs a review and decided to take a look. Here is a short summary: * Patches apply to the master branch. There are a trailing whitespaces, though. * All tests pass. * I see 8-10% performance improvement on full text search queries. * It seems that there

Re: [HACKERS] WIP Patch: Precalculate stable functions, infrastructure v1

On Thu, May 4, 2017 at 7:51 PM, Marina Polyakova wrote: > and here I send infrastructure patch which includes <...> >> > > Next 2 patches: > > Patch 'planning and execution', which includes: > - replacement nonvolatile functions and operators by appropriate cached >

Re: [HACKERS] WIP Patch: Precalculate stable functions, infrastructure v1

and here I send infrastructure patch which includes <...> Next 2 patches: Patch 'planning and execution', which includes: - replacement nonvolatile functions and operators by appropriate cached expressions; - planning and execution cached expressions; - regression tests. Patch 'costs',

[HACKERS] WIP Patch: Precalculate stable functions, infrastructure v1

Hello everyone again! This is the continuation of my previous patch on the same topic; here there are changes made thanks to Tom Lane comments (see thread here [1]). To not send big patch I have split it (that's why version starts with the first again) and here I send infrastructure patch