Re: [HACKERS] WIP patch for avoiding duplicate initdb runs during "make check"

2017-07-03 Thread Michael Paquier
On Mon, Jul 3, 2017 at 11:00 PM, Tom Lane wrote: > Michael Paquier writes: >> On Mon, Jul 3, 2017 at 9:25 PM, Greg Stark wrote: >>> On 2 July 2017 at 18:33, Tom Lane wrote: system("cp -a ...") call in favor

Re: [HACKERS] WIP patch for avoiding duplicate initdb runs during "make check"

2017-07-03 Thread Tom Lane
Michael Paquier writes: > On Mon, Jul 3, 2017 at 9:25 PM, Greg Stark wrote: >> On 2 July 2017 at 18:33, Tom Lane wrote: >>> system("cp -a ...") call in favor of something more portable. >> If we're ok with using Perl there's

Re: [HACKERS] WIP patch for avoiding duplicate initdb runs during "make check"

2017-07-03 Thread Michael Paquier
On Mon, Jul 3, 2017 at 10:02 PM, Alvaro Herrera wrote: > Tom Lane wrote: > >> (Other unfinished work: teaching the MSVC scripts to use this, >> and teaching pg_upgrade's test script to use it.) > > Maybe it'd be simpler to rewrite pg_upgrade tests using PostgresNode >

Re: [HACKERS] WIP patch for avoiding duplicate initdb runs during "make check"

2017-07-03 Thread Alvaro Herrera
Tom Lane wrote: > (Other unfinished work: teaching the MSVC scripts to use this, > and teaching pg_upgrade's test script to use it.) Maybe it'd be simpler to rewrite pg_upgrade tests using PostgresNode instead? -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] WIP patch for avoiding duplicate initdb runs during "make check"

2017-07-03 Thread Michael Paquier
On Mon, Jul 3, 2017 at 9:25 PM, Greg Stark wrote: > On 2 July 2017 at 18:33, Tom Lane wrote: >> system("cp -a ...") call in favor of something more portable. > > If we're ok with using Perl there's File::Copy::Recursive::dircopy() > which does exactly that.

Re: [HACKERS] WIP patch for avoiding duplicate initdb runs during "make check"

2017-07-03 Thread Greg Stark
On 2 July 2017 at 18:33, Tom Lane wrote: > system("cp -a ...") call in favor of something more portable. If we're ok with using Perl there's File::Copy::Recursive::dircopy() which does exactly that. -- greg -- Sent via pgsql-hackers mailing list

[HACKERS] WIP patch for avoiding duplicate initdb runs during "make check"

2017-07-02 Thread Tom Lane
Yesterday I spent a bit of time on an idea that we've talked about before, which is to not run initdb over and over again in contexts like "make check-world", or even just during "make check" in contrib or in the recovery or subscription tests. The idea would be to do it once and then copy the