Re: [HACKERS] WIP patch for latestCompletedXid method of computing snapshot xmax

2007-09-08 Thread Gregory Stark
"Josh Berkus" <[EMAIL PROTECTED]> writes: > Hmmm. Your results are withing the margin of error for DBT2, so they show no > real difference. What we need for this is a heavy-read workload, though; on > a workload like DBT2 (which is mostly writes) I wouldn't expect lazy-XID to > help much. T

Re: [HACKERS] WIP patch for latestCompletedXid method of computing snapshot xmax

2007-09-08 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > My desktop machine has a single consumer-grade IDE drive, and even with > fsync off and synchronous_commit off, it can barely make 190 tps sustained > pgbench throughput --- it's just disk write bound all the time. On a run > with 8 clients, 1 transacti

Re: [HACKERS] WIP patch for latestCompletedXid method of computing snapshot xmax

2007-09-08 Thread Tom Lane
Josh Berkus <[EMAIL PROTECTED]> writes: > Is the latest version of the patch from -patches the one I should test? Yeah, the posted patch is the same as what I committed. regards, tom lane ---(end of broadcast)--- TIP 5: don'

Re: [HACKERS] WIP patch for latestCompletedXid method of computing snapshot xmax

2007-09-08 Thread Tom Lane
Josh Berkus <[EMAIL PROTECTED]> writes: > Hmmm. Your results are withing the margin of error for DBT2, so they > show no real difference. What we need for this is a heavy-read > workload, though; on a workload like DBT2 (which is mostly writes) I > wouldn't expect lazy-XID to help much. Lazy-XID

Re: [HACKERS] WIP patch for latestCompletedXid method of computing snapshot xmax

2007-09-08 Thread Josh Berkus
Markus, > I've just completed two dbt2 test runs on a mid-level system, with 4GB > RAM and a 7 disk SATA RAID 1+0 w/ BBU. Once with code as of 2007/09/05 > 18:00 (which is *before* the first lazy xid commit) and once with cvs > HEAD (2007/09/08 +latestCompletedXid.patch. Hmmm. Your results are

Re: [HACKERS] WIP patch for latestCompletedXid method of computing snapshot xmax

2007-09-08 Thread Markus Schiltknecht
Hello Tom, Tom Lane wrote: So on the strength of that, I'm going to go ahead and commit the patch, but I'd be interested to see benchmarks from people with access to better hardware. I've just completed two dbt2 test runs on a mid-level system, with 4GB RAM and a 7 disk SATA RAID 1+0 w/ BBU.

Re: [HACKERS] WIP patch for latestCompletedXid method of computing snapshot xmax

2007-09-08 Thread Josh Berkus
Tom, > So on the strength of that, I'm going to go ahead and commit the patch, > but I'd be interested to see benchmarks from people with access to > better hardware. Is the latest version of the patch from -patches the one I should test? -- Josh Berkus PostgreSQL @ Sun San Francisco -

Re: [HACKERS] WIP patch for latestCompletedXid method of computing snapshot xmax

2007-09-08 Thread Tom Lane
I wrote: > This patch implements Florian's idea about how to manage snapshot xmax > without the ugly and performance-losing tactic of taking XidGenLock and > ProcArrayLock at the same time. I had to do a couple of slightly klugy > things to get bootstrap and prepared transactions to work, but on t