Re: [HACKERS] WITH ORDINALITY planner improvements

2014-02-02 Thread Etsuro Fujita
(2014/02/01 8:01), Tom Lane wrote: > Bruce Momjian writes: >> On Thu, Aug 15, 2013 at 07:25:17PM +0900, Etsuro Fujita wrote: >>> Attached is an updated version of the patch. In that version the code for >>> the >>> newly added function build_function_pathkeys() has been made more simple by >>> u

Re: [HACKERS] WITH ORDINALITY planner improvements

2014-01-31 Thread Tom Lane
Bruce Momjian writes: > On Thu, Aug 15, 2013 at 07:25:17PM +0900, Etsuro Fujita wrote: >> Attached is an updated version of the patch. In that version the code for >> the >> newly added function build_function_pathkeys() has been made more simple by >> using the macro INTEGER_BTREE_FAM_OID. > I

Re: [HACKERS] WITH ORDINALITY planner improvements

2014-01-31 Thread Bruce Momjian
On Thu, Aug 15, 2013 at 07:25:17PM +0900, Etsuro Fujita wrote: > I wrote: > > I've reworked on the patch. > > Attached is an updated version of the patch. In that version the code for the > newly added function build_function_pathkeys() has been made more simple by > using the macro INTEGER_BTREE

Re: [HACKERS] WITH ORDINALITY planner improvements

2013-08-15 Thread Etsuro Fujita
I wrote: > I've reworked on the patch. Attached is an updated version of the patch. In that version the code for the newly added function build_function_pathkeys() has been made more simple by using the macro INTEGER_BTREE_FAM_OID. Thanks, Best regards, Etsuro Fujita ordinality-path-20130815.

Re: [HACKERS] WITH ORDINALITY planner improvements

2013-08-12 Thread Etsuro Fujita
> > However it occurs to me that the plan isn't ideal: > > > > postgres=# explain select * from generate_series(1,10) with ordinality > > as a(a,o) natural full outer join generate_series(1,5) with ordinality > > as b(b,o) ; > > QUERY PLAN > > -

[HACKERS] WITH ORDINALITY planner improvements

2013-07-31 Thread Greg Stark
On Mon, Jul 29, 2013 at 1:02 PM, Greg Stark wrote: > On Mon, Jul 29, 2013 at 8:56 AM, Craig Ringer wrote: >> Unless LATERAL provides a way to do lock-step iteration through a pair >> (or more) of functions I don't think we can get rid of SRFs [in select >> target lists] yet > > You don't even ne