Re: [HACKERS] Walsender doesn't process options passed in the startup packet

2010-09-13 Thread Heikki Linnakangas
On 13/09/10 08:10, Fujii Masao wrote: On Mon, Sep 13, 2010 at 12:32 PM, Tom Lanet...@sss.pgh.pa.us wrote: Huh? walsender has no business applying any per-user or per-database settings. Okay. I got rid of the access to pg_db_role_setting from the patch. I attached the updated version, which

Re: [HACKERS] Walsender doesn't process options passed in the startup packet

2010-09-13 Thread Heikki Linnakangas
On 13/09/10 08:10, Fujii Masao wrote: Okay. I got rid of the access to pg_db_role_setting from the patch. I attached the updated version, which makes walsender process the options passed in the startup packet, apply PostAuthDelay and initialize client encoding. Thanks, committed. I moved the

Re: [HACKERS] Walsender doesn't process options passed in the startup packet

2010-09-12 Thread Fujii Masao
On Fri, Sep 10, 2010 at 9:56 PM, Fujii Masao masao.fu...@gmail.com wrote: BTW, this issue seems to derive from the following commit. http://archives.postgresql.org/pgsql-committers/2010-04/msg00175.php it was previously using an untenable assumption that template1 would always be available to

Re: [HACKERS] Walsender doesn't process options passed in the startup packet

2010-09-12 Thread Tom Lane
Fujii Masao masao.fu...@gmail.com writes: On Fri, Sep 10, 2010 at 9:56 PM, Fujii Masao masao.fu...@gmail.com wrote: BTW, this issue seems to derive from the following commit. http://archives.postgresql.org/pgsql-committers/2010-04/msg00175.php it was previously using an untenable assumption

Re: [HACKERS] Walsender doesn't process options passed in the startup packet

2010-09-12 Thread Fujii Masao
On Mon, Sep 13, 2010 at 12:32 PM, Tom Lane t...@sss.pgh.pa.us wrote: Huh?  walsender has no business applying any per-user or per-database settings. Okay. I got rid of the access to pg_db_role_setting from the patch. I attached the updated version, which makes walsender process the options

[HACKERS] Walsender doesn't process options passed in the startup packet

2010-09-10 Thread Fujii Masao
Hi, I found walsender didn't process options (e.g., application_name in primary_conninfo) passed in the startup packet. The cause is that walsender doesn't execute process_postgres_switches() and SetConfigOption() in InitPostgres(). The attached patch fixes this bug. Regards, -- Fujii Masao

Re: [HACKERS] Walsender doesn't process options passed in the startup packet

2010-09-10 Thread Heikki Linnakangas
On 10/09/10 13:17, Fujii Masao wrote: Hi, I found walsender didn't process options (e.g., application_name in primary_conninfo) passed in the startup packet. The cause is that walsender doesn't execute process_postgres_switches() and SetConfigOption() in InitPostgres(). The attached patch

Re: [HACKERS] Walsender doesn't process options passed in the startup packet

2010-09-10 Thread Fujii Masao
On Fri, Sep 10, 2010 at 7:54 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: I found walsender didn't process options (e.g., application_name in primary_conninfo) passed in the startup packet. The cause is that walsender doesn't execute process_postgres_switches() and