Re: [HACKERS] What is CheckPoint.undo needed for?

2007-03-03 Thread Bruce Momjian
Patch applied. Thanks. --- Florian G. Pflug wrote: Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: I think you should increase pg_control version. And the WAL page-header version, since this also

Re: [HACKERS] What is CheckPoint.undo needed for?

2007-03-03 Thread Bruce Momjian
Patch applied. Thanks. --- Florian G. Pflug wrote: Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: I think you should increase pg_control version. And the WAL page-header version, since this also

Re: [HACKERS] What is CheckPoint.undo needed for?

2007-02-28 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. ---

Re: [HACKERS] What is CheckPoint.undo needed for?

2007-02-23 Thread Florian G. Pflug
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: I think you should increase pg_control version. And the WAL page-header version, since this also changes WAL contents. Here is an updated version. I've incremeted XLOG_PAGE_MAGIC and PG_CONTROL_VERSION by one. greetings, Florian

[HACKERS] What is CheckPoint.undo needed for?

2007-02-22 Thread Florian G. Pflug
Hi I'm trying to gain a better understanding of how the postgres xlog works - especially about the corner cases of wal replay. One thing that I do not understand is what CheckPoint.undo is used for. I grepped through the source, and only see very few references to it, which either just print

Re: [HACKERS] What is CheckPoint.undo needed for?

2007-02-22 Thread Teodor Sigaev
What am I missing? Seems, it's about that http://archives.postgresql.org/pgsql-committers/2005-06/msg00085.php -- Teodor Sigaev E-mail: [EMAIL PROTECTED] WWW: http://www.sigaev.ru/

Re: [HACKERS] What is CheckPoint.undo needed for?

2007-02-22 Thread Teodor Sigaev
Opps, sorry, I missed checkpoint keyword Teodor Sigaev wrote: What am I missing? Seems, it's about that http://archives.postgresql.org/pgsql-committers/2005-06/msg00085.php -- Teodor Sigaev E-mail: [EMAIL PROTECTED]

Re: [HACKERS] What is CheckPoint.undo needed for?

2007-02-22 Thread Heikki Linnakangas
No you're right, it's related to the WAL undo stuff that was never actually implemented. It's dead code. Teodor Sigaev wrote: Opps, sorry, I missed checkpoint keyword Teodor Sigaev wrote: What am I missing? Seems, it's about that

Re: [HACKERS] What is CheckPoint.undo needed for?

2007-02-22 Thread Florian G. Pflug
Heikki Linnakangas wrote: No you're right, it's related to the WAL undo stuff that was never actually implemented. It's dead code. Teodor Sigaev wrote: Opps, sorry, I missed checkpoint keyword Teodor Sigaev wrote: What am I missing? Seems, it's about that

Re: [HACKERS] What is CheckPoint.undo needed for?

2007-02-22 Thread Alvaro Herrera
Florian G. Pflug wrote: Heikki Linnakangas wrote: No you're right, it's related to the WAL undo stuff that was never actually implemented. It's dead code. Teodor Sigaev wrote: Opps, sorry, I missed checkpoint keyword Teodor Sigaev wrote: What am I missing? Seems, it's about that

Re: [HACKERS] What is CheckPoint.undo needed for?

2007-02-22 Thread Florian G. Pflug
Alvaro Herrera wrote: Florian G. Pflug wrote: Heikki Linnakangas wrote: No you're right, it's related to the WAL undo stuff that was never actually implemented. It's dead code. Teodor Sigaev wrote: Opps, sorry, I missed checkpoint keyword Teodor Sigaev wrote: What am I missing? Seems,

Re: [HACKERS] What is CheckPoint.undo needed for?

2007-02-22 Thread Alvaro Herrera
Florian G. Pflug wrote: Alvaro Herrera wrote: Florian G. Pflug wrote: Heikki Linnakangas wrote: No you're right, it's related to the WAL undo stuff that was never actually implemented. It's dead code. Teodor Sigaev wrote: Opps, sorry, I missed checkpoint keyword Teodor Sigaev wrote:

Re: [HACKERS] What is CheckPoint.undo needed for?

2007-02-22 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: I think you should increase pg_control version. And the WAL page-header version, since this also changes WAL contents. regards, tom lane ---(end of broadcast)--- TIP 1: if