Re: [HACKERS] What use case is make_tuple_indirect() supposed to illustrate?

2014-04-23 Thread Andres Freund
Hi, On 2014-04-22 20:22:23 -0400, Tom Lane wrote: > And for that matter, it's a bit silly to be testing make_tuple_indirect > in a BEFORE INSERT/UPDATE trigger, because even if the tuple gets out > of the trigger without being flattened, it will certainly get flattened > mere nanoseconds later bef

[HACKERS] What use case is make_tuple_indirect() supposed to illustrate?

2014-04-22 Thread Tom Lane
Pursuant to http://www.postgresql.org/message-id/29007.1396038...@sss.pgh.pa.us I've been working on a patch to prevent external toast pointers from appearing in composite Datums. I noticed that this patch completely breaks the make_tuple_indirect() test case added by commit 36820250. The regressi