Re: [HACKERS] Why can't we used CAPITAL LETTERS into replication slot_name?

2015-10-03 Thread Andres Freund
Hi, On 2015-09-25 17:39:41 +0530, Rushabh Lathia wrote: > PFA patch to fix the hint message. The patched missed updating the regression test output files ;) Committed and backpatched back to 9.4. Thanks! - Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make ch

Re: [HACKERS] Why can't we used CAPITAL LETTERS into replication slot_name?

2015-09-25 Thread Rushabh Lathia
Thanks Andres. PFA patch to fix the hint message. On Fri, Sep 25, 2015 at 5:34 PM, Andres Freund wrote: > Hi, > > On 2015-09-25 17:32:39 +0530, Rushabh Lathia wrote: > > I am just wondering why pg_create_physical_replication_slot() can't take > > CAPITAL LETTERS into slot_name ? > > Windows. An

Re: [HACKERS] Why can't we used CAPITAL LETTERS into replication slot_name?

2015-09-25 Thread Andres Freund
Hi, On 2015-09-25 17:32:39 +0530, Rushabh Lathia wrote: > I am just wondering why pg_create_physical_replication_slot() can't take > CAPITAL LETTERS into slot_name ? Windows. And OSX. Specifically case-insensitive filenames. > If its by design then was should atleast change the hint into > Repli

[HACKERS] Why can't we used CAPITAL LETTERS into replication slot_name?

2015-09-25 Thread Rushabh Lathia
Hi, I am just wondering why pg_create_physical_replication_slot() can't take CAPITAL LETTERS into slot_name ? Comment over ReplicationSlotValidateName() says that - Slot names may consist out of [a-z0-9_]{1,NAMEDATALEN-1} which should allow the name to be used as a directory name on every support