Re: [HACKERS] Wrong error message in REINDEX command

2015-03-08 Thread Tom Lane
Sawada Masahiko sawada.m...@gmail.com writes:
 I got wrong error message when I did REINDEX SYSTEM command in
 transaction as follows.
 It should say ERROR:  REINDEX SYSTEM cannot run inside a transaction block
 Attached patch fixes it.

Hm, yeah, looks like ReindexObject() has a similar disease internally
(not to mention being very inappropriately named itself...)

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] Wrong error message in REINDEX command

2015-03-07 Thread Sawada Masahiko
Hi,

I got wrong error message when I did REINDEX SYSTEM command in
transaction as follows.
It should say ERROR:  REINDEX SYSTEM cannot run inside a transaction block
Attached patch fixes it.

[postgres][5432](1)=# begin;
BEGIN
[postgres][5432](1)=# reindex system postgres;
ERROR:  REINDEX DATABASE cannot run inside a transaction block
STATEMENT:  reindex system postgres;

Regards,

---
Sawada Masahiko


fix_reindex_error_message.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers