Re: [HACKERS] adding the commit to a patch's thread

[Daniel Gustafsson]

> On 03 Sep 2017, at 21:12, Magnus Hagander  wrote:
> 
> On Sun, Sep 3, 2017 at 8:55 PM, Daniel Gustafsson  > wrote:
> 
> That leaves us back at parsing/scraping -committers and adding the mailthread.
> For this CF I can add the commits manually, since attaching a thread isn’t
> limited to threads in -hackers.  This way we have more time to figure out an
> automated way for the next CF.  I’ve added the commit for my patch here as an
> example:
> 
> https://commitfest.postgresql.org/14/1245/ 
> 
> 
> That's a good start.

I will do that for commited patches.

> We can also add a separate field that's just a comma separated list of commit 
> hashes that auto-links to the git server if we want. *That* would be a 
> trivial addition. Actually auto-populating it would probably be a lot less 
> so, but for a manually managed one it should be fairly easy.

We can do that as well in case we want to, one doesn’t exclude the other.
Having both a link to the thread on -committers as well as a link to Git would
be neat (the former will neatly capture discussions on -committers that lead to
follow-up patches, something the latter will struggle with since it will be
lots extra work).

cheers ./daniel

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] adding the commit to a patch's thread

[Magnus Hagander]

On Sun, Sep 3, 2017 at 8:55 PM, Daniel Gustafsson  wrote:

> > On 03 Sep 2017, at 19:33, Magnus Hagander  wrote:
> >
> > On Sun, Sep 3, 2017 at 12:00 AM, Daniel Gustafsson  > wrote:
> > > On 01 Sep 2017, at 15:40, Robert Haas > wrote:
> > >
> > > On Fri, Sep 1, 2017 at 4:26 AM, Alvaro Herrera <
> alvhe...@alvh.no-ip.org > wrote:
> > >> Erik Rijkers wrote:
> > >>> Would it be possible to change the commitfest a bit and make it
> possible to
> > >>> add the commit (or commit-message, or hash) to the thread in the
> > >>> commitfest-app.
> > >>
> > >> +1 to add one or more commit hashes to CF entry metadata.
> > >>
> > >> (Back-filling for old entries welcome)
> > >
> > > Couldn't the CF app scrape the commit messages for references to
> > > threads, and if the commit message points to a thread with exactly 1
> > > patch record, associate the commit to that patch?
> >
> > Since there is a Gitlink field in the patch metadata, we could start
> simple
> > with setting that to link to the commit on pg gitweb?  While adding the
> thread
> > of the commit from -committers would be great as well, this gets us off
> the
> > ground quickly.
> >
> > The original idea behind the gitlink field was to link to a git
> repo/branch representing the patch, for people who preferred to publish
> full branches for those that want it.
> >
> > This has been done for a grand total of 43 patches throughout (out of a
> total of 1231).
> >
> > Not sure if that's enough to say "let's not repurpose it”?
>
> My thinking was that it wasn’t really repurposing, since the commit is
> quite
> representative of the patch and comma separated list could house both
> (especially since the former usecase is quite rate).  Looking at the code
> however, the Gitlink is a UrlField which I believe won’t support that so
> it’s
> dead in the water either way.
>

I think that would definitely be repurposing it since it's not used for
that in the past :)


That leaves us back at parsing/scraping -committers and adding the
> mailthread.
> For this CF I can add the commits manually, since attaching a thread isn’t
> limited to threads in -hackers.  This way we have more time to figure out
> an
> automated way for the next CF.  I’ve added the commit for my patch here as
> an
> example:
>
> https://commitfest.postgresql.org/14/1245/


That's a good start.

We can also add a separate field that's just a comma separated list of
commit hashes that auto-links to the git server if we want. *That* would be
a trivial addition. Actually auto-populating it would probably be a lot
less so, but for a manually managed one it should be fairly easy.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ 
 Work: https://www.redpill-linpro.com/ 

Re: [HACKERS] adding the commit to a patch's thread

[Daniel Gustafsson]

> On 03 Sep 2017, at 19:33, Magnus Hagander  wrote:
> 
> On Sun, Sep 3, 2017 at 12:00 AM, Daniel Gustafsson  > wrote:
> > On 01 Sep 2017, at 15:40, Robert Haas  > > wrote:
> >
> > On Fri, Sep 1, 2017 at 4:26 AM, Alvaro Herrera  > > wrote:
> >> Erik Rijkers wrote:
> >>> Would it be possible to change the commitfest a bit and make it possible 
> >>> to
> >>> add the commit (or commit-message, or hash) to the thread in the
> >>> commitfest-app.
> >>
> >> +1 to add one or more commit hashes to CF entry metadata.
> >>
> >> (Back-filling for old entries welcome)
> >
> > Couldn't the CF app scrape the commit messages for references to
> > threads, and if the commit message points to a thread with exactly 1
> > patch record, associate the commit to that patch?
> 
> Since there is a Gitlink field in the patch metadata, we could start simple
> with setting that to link to the commit on pg gitweb?  While adding the thread
> of the commit from -committers would be great as well, this gets us off the
> ground quickly.
> 
> The original idea behind the gitlink field was to link to a git repo/branch 
> representing the patch, for people who preferred to publish full branches for 
> those that want it.
> 
> This has been done for a grand total of 43 patches throughout (out of a total 
> of 1231).
> 
> Not sure if that's enough to say "let's not repurpose it”?

My thinking was that it wasn’t really repurposing, since the commit is quite
representative of the patch and comma separated list could house both
(especially since the former usecase is quite rate).  Looking at the code
however, the Gitlink is a UrlField which I believe won’t support that so it’s
dead in the water either way.

That leaves us back at parsing/scraping -committers and adding the mailthread.
For this CF I can add the commits manually, since attaching a thread isn’t
limited to threads in -hackers.  This way we have more time to figure out an
automated way for the next CF.  I’ve added the commit for my patch here as an
example:

https://commitfest.postgresql.org/14/1245/

cheers ./daniel

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] adding the commit to a patch's thread

[Magnus Hagander]

On Sun, Sep 3, 2017 at 12:00 AM, Daniel Gustafsson  wrote:

> > On 01 Sep 2017, at 15:40, Robert Haas  wrote:
> >
> > On Fri, Sep 1, 2017 at 4:26 AM, Alvaro Herrera 
> wrote:
> >> Erik Rijkers wrote:
> >>> Would it be possible to change the commitfest a bit and make it
> possible to
> >>> add the commit (or commit-message, or hash) to the thread in the
> >>> commitfest-app.
> >>
> >> +1 to add one or more commit hashes to CF entry metadata.
> >>
> >> (Back-filling for old entries welcome)
> >
> > Couldn't the CF app scrape the commit messages for references to
> > threads, and if the commit message points to a thread with exactly 1
> > patch record, associate the commit to that patch?
>
> Since there is a Gitlink field in the patch metadata, we could start simple
> with setting that to link to the commit on pg gitweb?  While adding the
> thread
> of the commit from -committers would be great as well, this gets us off the
> ground quickly.
>

The original idea behind the gitlink field was to link to a git repo/branch
representing the patch, for people who preferred to publish full branches
for those that want it.

This has been done for a grand total of 43 patches throughout (out of a
total of 1231).

Not sure if that's enough to say "let's not repurpose it"?

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ 
 Work: https://www.redpill-linpro.com/ 

Re: [HACKERS] adding the commit to a patch's thread

[Daniel Gustafsson]

> On 01 Sep 2017, at 15:40, Robert Haas  wrote:
> 
> On Fri, Sep 1, 2017 at 4:26 AM, Alvaro Herrera  
> wrote:
>> Erik Rijkers wrote:
>>> Would it be possible to change the commitfest a bit and make it possible to
>>> add the commit (or commit-message, or hash) to the thread in the
>>> commitfest-app.
>> 
>> +1 to add one or more commit hashes to CF entry metadata.
>> 
>> (Back-filling for old entries welcome)
> 
> Couldn't the CF app scrape the commit messages for references to
> threads, and if the commit message points to a thread with exactly 1
> patch record, associate the commit to that patch?

Since there is a Gitlink field in the patch metadata, we could start simple
with setting that to link to the commit on pg gitweb?  While adding the thread
of the commit from -committers would be great as well, this gets us off the
ground quickly.

Unless there are objections, I’ll ensure that this is maintained during this CF
as part of my commitfest tinkering.

cheers ./daniel

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] adding the commit to a patch's thread

[Robert Haas]

On Fri, Sep 1, 2017 at 4:26 AM, Alvaro Herrera  wrote:
> Erik Rijkers wrote:
>> Would it be possible to change the commitfest a bit and make it possible to
>> add the commit (or commit-message, or hash) to the thread in the
>> commitfest-app.
>
> +1 to add one or more commit hashes to CF entry metadata.
>
> (Back-filling for old entries welcome)

Couldn't the CF app scrape the commit messages for references to
threads, and if the commit message points to a thread with exactly 1
patch record, associate the commit to that patch?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] adding the commit to a patch's thread

[Alvaro Herrera]

Erik Rijkers wrote:

> Would it be possible to change the commitfest a bit and make it possible to
> add the commit (or commit-message, or hash) to the thread in the
> commitfest-app.

+1 to add one or more commit hashes to CF entry metadata.

(Back-filling for old entries welcome)

-- 
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] adding the commit to a patch's thread

[Michael Paquier]

On Fri, Sep 1, 2017 at 1:11 PM, Erik Rijkers  wrote:
> Would it be possible to change the commitfest a bit and make it possible to
> add the commit (or commit-message, or hash) to the thread in the
> commitfest-app.  I would think it would be best to make it so that when the
> thread gets set to state 'committed', the actual commit/hash is added
> somewhere at the same time.

There could be multiple commits. One thing that can be done now is to
add an annotation with the message telling that a portion has been
committed, and mention the commit number involved, say with the first
7-8 characters.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] adding the commit to a patch's thread

[Erik Rijkers]

At the moment it's not easy to find the commit that terminates a 
commitfest thread about a patch.  One has to manually compare dates and 
guess what belongs to what.  The commit message nowadays often has the 
link to the thread ("Discussion") but the other way around is often not 
so easily found.


For example: looking at

  https://commitfest.postgresql.org/14/1020/

One cannot directly find the actual commit that finished it.

Would it be possible to change the commitfest a bit and make it possible 
to add the commit (or commit-message, or hash) to the thread in the 
commitfest-app.  I would think it would be best to make it so that when 
the thread gets set to state 'committed', the actual commit/hash is 
added somewhere at the same time.



thanks,

Erik Rijkers



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers