Re: [HACKERS] argtype_inherit() is dead code

2005-04-20 Thread Dave Held
-Original Message- From: Jim C. Nasby [mailto:[EMAIL PROTECTED] Sent: Tuesday, April 19, 2005 5:56 PM To: Christopher Browne Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] argtype_inherit() is dead code [...] On Sun, Apr 17, 2005 at 07:01:41PM -0400, Christopher Browne

Re: [HACKERS] argtype_inherit() is dead code

2005-04-19 Thread Jim C. Nasby
On Sun, Apr 17, 2005 at 07:01:41PM -0400, Christopher Browne wrote: The world rejoiced as [EMAIL PROTECTED] (Jim C. Nasby) wrote: On Sun, Apr 17, 2005 at 06:56:01AM -0700, Joshua D. Drake wrote: Is it really an important area to improve, or are there other priorities? I know some people

Re: [HACKERS] argtype_inherit() is dead code

2005-04-18 Thread Chuck McDevitt
, 2005 6:56 AM To: Alvaro Herrera Cc: Tom Lane; elein; pgsql-hackers@postgresql.org Subject: Re: [HACKERS] argtype_inherit() is dead code Is it really an important area to improve, or are there other priorities? I know some people wished we had better support for inheritance, but how strong

Re: [HACKERS] argtype_inherit() is dead code

2005-04-18 Thread Christopher Browne
The world rejoiced as [EMAIL PROTECTED] (Jim C. Nasby) wrote: On Sun, Apr 17, 2005 at 06:56:01AM -0700, Joshua D. Drake wrote: Is it really an important area to improve, or are there other priorities? I know some people wished we had better support for inheritance, but how strong is that

Re: [HACKERS] argtype_inherit() is dead code

2005-04-18 Thread Bruce Momjian
Alvaro Herrera wrote: On Sun, Apr 17, 2005 at 06:56:01AM -0700, Joshua D. Drake wrote: From a people who call me perspective. I am never asked about inheritance. Most of the people don't even know it is there. The requests I get are: Just wondering, does anybody asks you about the

Re: [HACKERS] argtype_inherit() is dead code

2005-04-18 Thread Joshua D. Drake
Alvaro Herrera wrote: On Sun, Apr 17, 2005 at 06:56:01AM -0700, Joshua D. Drake wrote: From a people who call me perspective. I am never asked about inheritance. Most of the people don't even know it is there. The requests I get are: Just wondering, does anybody asks you about the excessive

Re: [HACKERS] argtype_inherit() is dead code

2005-04-17 Thread Joshua D. Drake
Is it really an important area to improve, or are there other priorities? I know some people wished we had better support for inheritance, but how strong is that wish? Hello, From a people who call me perspective. I am never asked about inheritance. Most of the people don't even know it is

Re: [HACKERS] argtype_inherit() is dead code

2005-04-17 Thread Alvaro Herrera
On Sun, Apr 17, 2005 at 06:56:01AM -0700, Joshua D. Drake wrote: From a people who call me perspective. I am never asked about inheritance. Most of the people don't even know it is there. The requests I get are: Just wondering, does anybody asks you about the excessive locking (and

Re: [HACKERS] argtype_inherit() is dead code

2005-04-17 Thread elein
As the voice of someone who has a lot of experience with some of the original inheritance, I would prefer to have the select foo(t.*) from grandkid work for completeness. However, erroring out as ambiguous is not unreasonable since we have to cast the hell out of everything usually. I would

Re: [HACKERS] argtype_inherit() is dead code

2005-04-17 Thread Jim C. Nasby
On Sun, Apr 17, 2005 at 06:56:01AM -0700, Joshua D. Drake wrote: Is it really an important area to improve, or are there other priorities? I know some people wished we had better support for inheritance, but how strong is that wish? FWIW, I think people might be more likely to use the OO

Re: [HACKERS] argtype_inherit() is dead code

2005-04-17 Thread Rod Taylor
On Sun, 2005-04-17 at 14:04 -0400, Alvaro Herrera wrote: On Sun, Apr 17, 2005 at 06:56:01AM -0700, Joshua D. Drake wrote: From a people who call me perspective. I am never asked about inheritance. Most of the people don't even know it is there. The requests I get are: Just wondering,

Re: [HACKERS] argtype_inherit() is dead code

2005-04-17 Thread Rod Taylor
On Sun, 2005-04-17 at 19:54 -0400, Robert Treat wrote: On Sunday 17 April 2005 19:30, Rod Taylor wrote: On Sun, 2005-04-17 at 14:04 -0400, Alvaro Herrera wrote: On Sun, Apr 17, 2005 at 06:56:01AM -0700, Joshua D. Drake wrote: From a people who call me perspective. I am never asked about

Re: [HACKERS] argtype_inherit() is dead code

2005-04-17 Thread Robert Treat
On Sunday 17 April 2005 19:30, Rod Taylor wrote: On Sun, 2005-04-17 at 14:04 -0400, Alvaro Herrera wrote: On Sun, Apr 17, 2005 at 06:56:01AM -0700, Joshua D. Drake wrote: From a people who call me perspective. I am never asked about inheritance. Most of the people don't even know it is

Re: [HACKERS] argtype_inherit() is dead code

2005-04-17 Thread Christopher Kings-Lynne
From a people who call me perspective. I am never asked about inheritance. Most of the people don't even know it is there. The requests I get are: Just wondering, does anybody asks you about the excessive locking (and deadlocking) on foreign keys? The business about being able to drop users and

Re: [HACKERS] argtype_inherit() is dead code

2005-04-16 Thread elein
Are you saying that the code was supposed unflatten the arguments of a function into a possible composite type taking into consideration the possible inheritance information of the composite type? elein On Fri, Apr 15, 2005 at 08:04:36PM -0400, Tom Lane wrote: In parse_func.c there are routines

Re: [HACKERS] argtype_inherit() is dead code

2005-04-16 Thread Tom Lane
[EMAIL PROTECTED] (elein) writes: Are you saying that the code was supposed unflatten the arguments of a function into a possible composite type taking into consideration the possible inheritance information of the composite type? No, it didn't do that. AFAICT the case it was supposed to

Re: [HACKERS] argtype_inherit() is dead code

2005-04-16 Thread Alvaro Herrera
On Sat, Apr 16, 2005 at 03:39:55PM -0400, Tom Lane wrote: Digging in the CVS history, it appears that I may have broken it here: http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_coerce.c.diff?r1=2.35;r2=2.36;f=h It's quite possible that it failed even before that

Re: [HACKERS] argtype_inherit() is dead code

2005-04-16 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: Given the limitations of table inheritance, it doesn't surprise me that nobody really uses it to implement object-oriented programs. True. Is it really an important area to improve, or are there other priorities? There are certainly higher priorities,

[HACKERS] argtype_inherit() is dead code

2005-04-15 Thread Tom Lane
In parse_func.c there are routines argtype_inherit() and gen_cross_product() that date from Berkeley days. The comments explain their reason for existence thus: * This function is used to handle resolution of function calls when * there is no match to the given argument types, but there