Re: [HACKERS] bug in citext's upgrade script for parallel aggregates

2016-07-26 Thread Robert Haas
On Tue, Jul 26, 2016 at 3:48 AM, Noah Misch wrote: > On Thu, Jul 14, 2016 at 02:00:59AM +0200, Andreas Karlsson wrote: >> On 07/09/2016 05:42 AM, David Rowley wrote: >> >On 30 June 2016 at 03:49, Robert Haas wrote: >> >>On Sat, Jun 25, 2016 at 3:44 AM, Andreas Karlsson >> >>wrote: >> >>>On 06/2

Re: [HACKERS] bug in citext's upgrade script for parallel aggregates

2016-07-26 Thread Noah Misch
On Thu, Jul 14, 2016 at 02:00:59AM +0200, Andreas Karlsson wrote: > On 07/09/2016 05:42 AM, David Rowley wrote: > >On 30 June 2016 at 03:49, Robert Haas wrote: > >>On Sat, Jun 25, 2016 at 3:44 AM, Andreas Karlsson wrote: > >>>On 06/24/2016 01:31 PM, David Rowley wrote: > Seems there's a small

Re: [HACKERS] bug in citext's upgrade script for parallel aggregates

2016-07-23 Thread David Rowley
On 14 July 2016 at 02:00, Andreas Karlsson wrote: > On 07/09/2016 05:42 AM, David Rowley wrote: >> On 30 June 2016 at 03:49, Robert Haas wrote: >>> Since we've already released beta2, I think we need to do a whole new >>> extension version. We treated beta1 as a sufficiently-significant >>> even

Re: [HACKERS] bug in citext's upgrade script for parallel aggregates

2016-07-13 Thread Andreas Karlsson
On 07/09/2016 05:42 AM, David Rowley wrote: On 30 June 2016 at 03:49, Robert Haas wrote: On Sat, Jun 25, 2016 at 3:44 AM, Andreas Karlsson wrote: On 06/24/2016 01:31 PM, David Rowley wrote: Seems there's a small error in the upgrade script for citext for 1.1 to 1.2 which will cause min(citex

Re: [HACKERS] bug in citext's upgrade script for parallel aggregates

2016-07-08 Thread David Rowley
On 30 June 2016 at 03:49, Robert Haas wrote: > On Sat, Jun 25, 2016 at 3:44 AM, Andreas Karlsson wrote: >> On 06/24/2016 01:31 PM, David Rowley wrote: >>> Seems there's a small error in the upgrade script for citext for 1.1 >>> to 1.2 which will cause min(citext) not to be parallel enabled. >>> >

Re: [HACKERS] bug in citext's upgrade script for parallel aggregates

2016-06-29 Thread Robert Haas
On Sat, Jun 25, 2016 at 3:44 AM, Andreas Karlsson wrote: > On 06/24/2016 01:31 PM, David Rowley wrote: >> Seems there's a small error in the upgrade script for citext for 1.1 >> to 1.2 which will cause min(citext) not to be parallel enabled. >> >> max(citext)'s combinefunc is first set incorrectly

Re: [HACKERS] bug in citext's upgrade script for parallel aggregates

2016-06-25 Thread Andreas Karlsson
On 06/24/2016 01:31 PM, David Rowley wrote: Seems there's a small error in the upgrade script for citext for 1.1 to 1.2 which will cause min(citext) not to be parallel enabled. max(citext)'s combinefunc is first set incorrectly, but then updated to the correct value. I assume it was meant to se

[HACKERS] bug in citext's upgrade script for parallel aggregates

2016-06-24 Thread David Rowley
Seems there's a small error in the upgrade script for citext for 1.1 to 1.2 which will cause min(citext) not to be parallel enabled. max(citext)'s combinefunc is first set incorrectly, but then updated to the correct value. I assume it was meant to set the combine function for min(citext) instead.