Re: [HACKERS] calculation for NUM_FIXED_LWLOCKS

2014-06-19 Thread Amit Kapila
On Thu, Jun 19, 2014 at 7:41 PM, Kevin Grittner wrote: > > Kevin Grittner wrote: > > > Will commit a fix shortly. > > Fixed exactly as Amit suggested. Pushed to master and 9.4 branches. Thanks for looking into it. With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com

Re: [HACKERS] calculation for NUM_FIXED_LWLOCKS

2014-06-19 Thread Kevin Grittner
Kevin Grittner wrote: > Will commit a fix shortly. Fixed exactly as Amit suggested.  Pushed to master and 9.4 branches. Thanks! -- Kevin Grittner EDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] calculation for NUM_FIXED_LWLOCKS

2014-06-19 Thread Kevin Grittner
Amit Kapila wrote: > #define PREDICATELOCK_MANAGER_LWLOCK_OFFSET \ > (NUM_INDIVIDUAL_LWLOCKS + NUM_LOCK_PARTITIONS) > In this PREDICATELOCK_MANAGER_LWLOCK_OFFSET > should consider NUM_BUFFER_PARTITIONS which means > it should be: > > #define PREDICATELOCK_MANAGER_LWLOCK_OFFSET \ > (LOCK_MANAGER_

[HACKERS] calculation for NUM_FIXED_LWLOCKS

2014-06-19 Thread Amit Kapila
Currently the calculation for NUM_FIXED_LWLOCKS is as below, which I think has some problem: /* Offsets for various chunks of preallocated lwlocks. */ #define BUFFER_MAPPING_LWLOCK_OFFSET NUM_INDIVIDUAL_LWLOCKS #define LOCK_MANAGER_LWLOCK_OFFSET \ (BUFFER_MAPPING_LWLOCK_OFFSET + NUM_BUFFER_PAR