Re: [HACKERS] change alter user to be a true alias for alter role

2014-08-23 Thread Tom Lane
Jov writes: > I make the v2 of the patch,use Tom's advice. > But I can't make ROLE and USER in the keyword list,it is hard to solve the > conflict,or rewrite many gram rules. This patch seems to be trying to make ROLE and USER interchangeable *everywhere* in the grammar, which is moving the goalp

Re: [HACKERS] change alter user to be a true alias for alter role

2014-08-22 Thread Jov
I make the v2 of the patch,use Tom's advice. But I can't make ROLE and USER in the keyword list,it is hard to solve the conflict,or rewrite many gram rules. the problem is : role_or_user : ROLE | USER; xx_keyword:...| ROLE|...|USER..; this two rules produce conflict.So in v2,I remove ROLE and US

Re: [HACKERS] change alter user to be a true alias for alter role

2014-07-09 Thread Jov
Sorry for the late resp,I will try to update the patch. Jov blog: http:amutu.com/blog 2014-07-02 4:17 GMT+08:00 Abhijit Menon-Sen : > At 2014-06-27 16:11:21 +0200, vik.fear...@dalibo.com wrote: > > > > After a week of silence from Jov, I decided to do this myself since i

Re: [HACKERS] change alter user to be a true alias for alter role

2014-07-01 Thread Abhijit Menon-Sen
At 2014-06-27 16:11:21 +0200, vik.fear...@dalibo.com wrote: > > After a week of silence from Jov, I decided to do this myself since it > didn't seem very hard. > > Many frustrating hours of trying to understand why I'm getting > shift/reduce conflicts by the hundreds later, I've decided to give up

Re: [HACKERS] change alter user to be a true alias for alter role

2014-06-27 Thread Vik Fearing
On 06/19/2014 07:18 PM, Tom Lane wrote: > Jov writes: >> the doc say: >>> ALTER USER is now an alias for ALTER >>> ROLE > >> but alter user lack the following format: >> ... > > If we're going to have a policy that these commands b

Re: [HACKERS] change alter user to be a true alias for alter role

2014-06-19 Thread Vik Fearing
On 06/19/2014 07:18 PM, Tom Lane wrote: > Jov writes: >> the doc say: >>> ALTER USER is now an alias for ALTER >>> ROLE > >> but alter user lack the following format: >> ... > > If we're going to have a policy that these commands b

Re: [HACKERS] change alter user to be a true alias for alter role

2014-06-19 Thread Tom Lane
Jov writes: > the doc say: >> ALTER USER is now an alias for ALTER >> ROLE > but alter user lack the following format: > ... If we're going to have a policy that these commands be exactly equivalent, it seems like this patch is jus

Re: [HACKERS] change alter user to be a true alias for alter role

2014-06-19 Thread Vik Fearing
On 01/20/2014 03:31 PM, Jov wrote: > the doc say: > > ALTER USER is now an alias for ALTER ROLE > . > > > but alter user lack the following format: > > [...] > > this make alter user a true alias for alter role. This is

Re: [HACKERS] change alter user to be a true alias for alter role

2014-01-21 Thread Kevin Grittner
Jov wrote: > attach patch add the per database set for alter user Please add to the open CommitFest so that the patch doesn't "fall through the cracks": https://commitfest.postgresql.org/action/commitfest_view/open -- Kevin Grittner EDB: http://www.enterprisedb.com The Enterprise PostgreSQL Co

[HACKERS] change alter user to be a true alias for alter role

2014-01-20 Thread Jov
the doc say: > ALTER USER is now an alias for ALTER > ROLE > . but alter user lack the following format: > ALTER ROLE name [ IN DATABASE database_name ] SET configuration_parameter{ TO > | = } { > value | DEFAULT } > ALTER ROLE {