Re: [HACKERS] checking variadic "any" argument in parser - should be array

2013-07-16 Thread Pavel Stehule
2013/7/15 Andrew Dunstan : > > On 07/14/2013 12:28 AM, Pavel Stehule wrote: >> >> Hello >> >> 2013/7/14 Andrew Dunstan : >>> >>> On 06/29/2013 03:29 PM, Pavel Stehule wrote: >>> >>> >>> 5. This patch has user visibility, i.e. now we are throwing an error when user only sa

Re: [HACKERS] checking variadic "any" argument in parser - should be array

2013-07-15 Thread Andrew Dunstan
On 07/14/2013 12:28 AM, Pavel Stehule wrote: Hello 2013/7/14 Andrew Dunstan : On 06/29/2013 03:29 PM, Pavel Stehule wrote: 5. This patch has user visibility, i.e. now we are throwing an error when user only says "VARIADIC NULL" like: select concat(variadic NULL) is NULL; Previously

Re: [HACKERS] checking variadic "any" argument in parser - should be array

2013-07-13 Thread Pavel Stehule
Hello 2013/7/14 Andrew Dunstan : > > On 06/29/2013 03:29 PM, Pavel Stehule wrote: > > > >> 5. This patch has user visibility, i.e. now we are throwing an error >> when >> user only says "VARIADIC NULL" like: >> >> select concat(variadic NULL) is NULL; >> >> Previou

Re: [HACKERS] checking variadic "any" argument in parser - should be array

2013-07-13 Thread Andrew Dunstan
On 06/29/2013 03:29 PM, Pavel Stehule wrote: 5. This patch has user visibility, i.e. now we are throwing an error when user only says "VARIADIC NULL" like: select concat(variadic NULL) is NULL; Previously it was working but now we are throwing an error. Well we are now more stricter th

Re: [HACKERS] checking variadic "any" argument in parser - should be array

2013-07-02 Thread Jeevan Chalke
On Mon, Jul 1, 2013 at 8:36 PM, Pavel Stehule wrote: > 2013/6/29 Pavel Stehule : > > Hello > > > > updated patch - precious Assert, more comments > > > > Regards > > > > Pavel > > > > stripped > Thanks. Patch looks good to me now. Revalidated and didn't see any issue so marking "Ready For Commit

Re: [HACKERS] checking variadic "any" argument in parser - should be array

2013-07-01 Thread Pavel Stehule
2013/6/29 Pavel Stehule : > Hello > > updated patch - precious Assert, more comments > > Regards > > Pavel > stripped variadic_any_parser_check-3.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://ww

Re: [HACKERS] checking variadic "any" argument in parser - should be array

2013-07-01 Thread Alvaro Herrera
Pavel Stehule escribió: > Hello > > updated patch - precious Assert, more comments Pavel, can you please remove quoted text from messages you reply to? This message has 10kb of completely useless text. Thanks, -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development,

Re: [HACKERS] checking variadic "any" argument in parser - should be array

2013-06-29 Thread Pavel Stehule
Hello updated patch - precious Assert, more comments Regards Pavel 2013/6/29 Pavel Stehule : > 2013/6/28 Jeevan Chalke : >> Hi Pavel, >> >> >> On Fri, Jun 28, 2013 at 2:53 AM, Pavel Stehule >> wrote: >>> >>> Hello >>> >>> 2013/6/27 Jeevan Chalke : >>> > Hi Pavel, >>> > >>> > I had a look over

Re: [HACKERS] checking variadic "any" argument in parser - should be array

2013-06-29 Thread Pavel Stehule
2013/6/28 Jeevan Chalke : > Hi Pavel, > > > On Fri, Jun 28, 2013 at 2:53 AM, Pavel Stehule > wrote: >> >> Hello >> >> 2013/6/27 Jeevan Chalke : >> > Hi Pavel, >> > >> > I had a look over your new patch and it looks good to me. >> > >> > My review comments on patch: >> > >> > 1. It cleanly applies

Re: [HACKERS] checking variadic "any" argument in parser - should be array

2013-06-28 Thread Jeevan Chalke
Hi Pavel, On Fri, Jun 28, 2013 at 2:53 AM, Pavel Stehule wrote: > Hello > > 2013/6/27 Jeevan Chalke : > > Hi Pavel, > > > > I had a look over your new patch and it looks good to me. > > > > My review comments on patch: > > > > 1. It cleanly applies with patch -p1 command. > > 2. make/make instal

Re: [HACKERS] checking variadic "any" argument in parser - should be array

2013-06-27 Thread Pavel Stehule
Hello 2013/6/27 Jeevan Chalke : > Hi Pavel, > > I had a look over your new patch and it looks good to me. > > My review comments on patch: > > 1. It cleanly applies with patch -p1 command. > 2. make/make install/make check were smooth. > 3. My own testing didn't find any issue. > 4. I had a code w

Re: [HACKERS] checking variadic "any" argument in parser - should be array

2013-06-27 Thread Jeevan Chalke
Hi Pavel, I had a look over your new patch and it looks good to me. My review comments on patch: 1. It cleanly applies with patch -p1 command. 2. make/make install/make check were smooth. 3. My own testing didn't find any issue. 4. I had a code walk-through and I am little bit worried or confuse

Re: [HACKERS] checking variadic "any" argument in parser - should be array

2013-06-26 Thread Pavel Stehule
Hello remastered version Regards Pavel 2013/6/26 Jeevan Chalke : > Hi Pavel > > > On Sat, Jan 26, 2013 at 9:22 AM, Pavel Stehule > wrote: >> >> Hello Tom >> >> you did comment >> >> ! <><--><--> * Non-null argument had better be an array. >> The parser doesn't >> ! <><--><-

Re: [HACKERS] checking variadic "any" argument in parser - should be array

2013-06-26 Thread Jeevan Chalke
Hi Pavel On Sat, Jan 26, 2013 at 9:22 AM, Pavel Stehule wrote: > Hello Tom > > you did comment > > ! <><--><--> * Non-null argument had better be an array. > The parser doesn't > ! <><--><--> * enforce this for VARIADIC ANY functions > (maybe it should?), so > ! <><--

[HACKERS] checking variadic "any" argument in parser - should be array

2013-01-25 Thread Pavel Stehule
Hello Tom you did comment ! <><--><--> * Non-null argument had better be an array. The parser doesn't ! <><--><--> * enforce this for VARIADIC ANY functions (maybe it should?), so ! <><--><--> * that check uses ereport not just elog. ! <><--><--> */