Re: [HACKERS] compile error with -DOPTIMIZER_DEBUG

2009-12-02 Thread Alvaro Herrera
Tom Lane wrote: Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: Jan Urbański wrote: ISTM that there's a superfluous curly brace in print_path (which only gets compiled with -DOPTIMIZER_DEBUG. Thanks, committed. You know, the last couple of times I've touched that code,

Re: [HACKERS] compile error with -DOPTIMIZER_DEBUG

2009-11-29 Thread Bruce Momjian
Tom Lane wrote: Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: Jan Urba??ski wrote: ISTM that there's a superfluous curly brace in print_path (which only gets compiled with -DOPTIMIZER_DEBUG. Thanks, committed. You know, the last couple of times I've touched that

Re: [HACKERS] compile error with -DOPTIMIZER_DEBUG

2009-11-29 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Tom Lane wrote: You know, the last couple of times I've touched that code, I've been wondering why we bother to maintain it. Personally I always use pprint() when I'm interested in a printout of a plan tree. Is anyone actually using the printout code

[HACKERS] compile error with -DOPTIMIZER_DEBUG

2009-11-22 Thread Jan Urbański
Hi, ISTM that there's a superfluous curly brace in print_path (which only gets compiled with -DOPTIMIZER_DEBUG. Patch attached. Jan diff --git a/src/backend/optimizer/path/allpaths.c b/src/backend/optimizer/path/allpaths.c index bfadcb0..6b2f86c 100644 ---

Re: [HACKERS] compile error with -DOPTIMIZER_DEBUG

2009-11-22 Thread Heikki Linnakangas
Jan Urbański wrote: ISTM that there's a superfluous curly brace in print_path (which only gets compiled with -DOPTIMIZER_DEBUG. Patch attached. Thanks, committed. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list

Re: [HACKERS] compile error with -DOPTIMIZER_DEBUG

2009-11-22 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: Jan Urbański wrote: ISTM that there's a superfluous curly brace in print_path (which only gets compiled with -DOPTIMIZER_DEBUG. Thanks, committed. You know, the last couple of times I've touched that code, I've been wondering