Re: [HACKERS] contrib/pg_stat_statements 1212

2008-12-22 Thread Alex Hunsaker
On Mon, Dec 22, 2008 at 00:44, ITAGAKI Takahiro itagaki.takah...@oss.ntt.co.jp wrote: Alex Hunsaker bada...@gmail.com wrote: A few comments: Is there a reason you add sourceText to QueryDesc? AFAICT you can do ActivePortal-sourceText and it will always be populated correctly. That's for

Re: [HACKERS] contrib/pg_stat_statements 1212

2008-12-21 Thread ITAGAKI Takahiro
Alex Hunsaker bada...@gmail.com wrote: A few comments: Is there a reason you add sourceText to QueryDesc? AFAICT you can do ActivePortal-sourceText and it will always be populated correctly. That's for nested statements (SQLs called in stored functions). ActivePortal-sourceText shows text

Re: [HACKERS] contrib/pg_stat_statements 1212

2008-12-13 Thread Euler Taveira de Oliveira
ITAGAKI Takahiro escreveu: - A new GUC variable 'explain_analyze_format' is added. I'm afraid that this variable name doesn't tell what it means. What about 'explain_analyze_stats_format' or even 'explain_stats_format'? -- Euler Taveira de Oliveira http://www.timbira.com/ -- Sent via

[HACKERS] contrib/pg_stat_statements 1212

2008-12-12 Thread ITAGAKI Takahiro
Here is an updated version of pg_stat_statements. [Changes] - A new GUC variable 'explain_analyze_format' is added. - Statistics counters are converted into a variable 'BufferStats'. Vladimir Sitnikov sitnikov.vladi...@gmail.com wrote: Can I ask my question once again? Why don't you want to