Re: [HACKERS] contrib/pg_stat_statements v2

2008-11-01 Thread Vladimir Sitnikov
Hello, I have two concerns regarding the patch: A) I am not sure if it is good to have a single contention point (pgss-lock = LWLockAssign()). I guess that would impact scalability, especially on a multi-cpu systems. I guess the real solution will come when PostgreSQL have a pool for sql

[HACKERS] contrib/pg_stat_statements v2

2008-10-27 Thread ITAGAKI Takahiro
Here is an updated version of contrib/pg_stat_statements module. I wrote: A shutdown hook is probably not needed because I can use proc_exit() or shmem_exit() for the purpose. I added shutdown hook eventually because MyProc has been reset already in on_shmem_exit(). A callback that resets