Re: [HACKERS] contrib/snapshot

2011-01-03 Thread Joel Jacobson
2011/1/3 Andrew Dunstan > "contrib" in PostgreSQL means "a module maintained by the backend > developers". > But it's not clear to me that there is any particular reason why this should > be in contrib. > Then I definitively think contrib is the only possible place for this module. If the module

Re: [HACKERS] contrib/snapshot

2011-01-03 Thread Jim Nasby
On Jan 2, 2011, at 6:50 PM, Joel Jacobson wrote: > 2011/1/3 Joel Jacobson > 2011/1/2 Jim Nasby > Is it actually limited to functions? ISTM this concept would be valuable for > anything that's not in pg_class (in other words, anything that doesn't have > user data in it). > > Instead of limitin

Re: [HACKERS] contrib/snapshot

2011-01-02 Thread Andrew Dunstan
On 01/02/2011 07:44 PM, Joel Jacobson wrote: Also, I'm not sure why this needs to be in contrib vs pgFoundry. Good point. It's actually in neither of them right now, it's only at github.com :) I merely used the prefix contrib/ in the subject line to indicate it's no

Re: [HACKERS] contrib/snapshot

2011-01-02 Thread Joel Jacobson
2011/1/3 Joel Jacobson > 2011/1/2 Jim Nasby > >> Is it actually limited to functions? ISTM this concept would be valuable >> for anything that's not in pg_class (in other words, anything that doesn't >> have user data in it). >> > > Instead of limiting the support to functions, perhaps it would

Re: [HACKERS] contrib/snapshot

2011-01-02 Thread Joel Jacobson
2011/1/2 Jim Nasby > > Renamed to fsnapshot. > > Is it actually limited to functions? ISTM this concept would be valuable > for anything that's not in pg_class (in other words, anything that doesn't > have user data in it). > My ambition is to primarily support functions. Support for other objec

Re: [HACKERS] contrib/snapshot

2011-01-02 Thread Jim Nasby
On Dec 31, 2010, at 1:35 PM, Joel Jacobson wrote: > 2010/12/31 Simon Riggs > Please call it something other than "snapshot". There's already about 3 > tools called something similar and a couple of different meanings of the > term in the world of Postgres. > > > Thanks, good point. > Renamed to

Re: [HACKERS] contrib/snapshot

2011-01-01 Thread Joel Jacobson
2010/12/31 Simon Riggs > Please call it something other than "snapshot". There's already about 3 > tools called something similar and a couple of different meanings of the > term in the world of Postgres. > > Renamed the entire github project as well: https://github.com/gluefinance/fsnapshot --

Re: [HACKERS] contrib/snapshot

2010-12-31 Thread pasman pasmański
Hi. Will be useful to add a column with timestamp of the revision and a comment can you do it? not today in order that your friends dont kill you .. -- Sent from my mobile device pasman -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your s

Re: [HACKERS] contrib/snapshot

2010-12-31 Thread Joel Jacobson
2010/12/31 Simon Riggs > Please call it something other than "snapshot". There's already about 3 > tools called something similar and a couple of different meanings of the > term in the world of Postgres. > > Thanks, good point. Renamed to fsnapshot. Commit. -- Best regards, Joel Jacobson Glue

Re: [HACKERS] contrib/snapshot

2010-12-31 Thread Simon Riggs
On Fri, 2010-12-31 at 14:00 +0100, Joel Jacobson wrote: > This is the first alpha release of a new hopefully quite interesting > little tool, named "snapshot". Please call it something other than "snapshot". There's already about 3 tools called something similar and a couple of different meanings

Re: [HACKERS] contrib/snapshot

2010-12-31 Thread David E. Wheeler
On Dec 31, 2010, at 10:15 AM, Joel Jacobson wrote: > 2010/12/31 David E. Wheeler > This looks awesome, Joel! One question: Why the dependence on pg_crypto? If > it's just for SHA1 support, and you're just using it to to create hashes of > function bodies, I suspect that you could also use the c

Re: [HACKERS] contrib/snapshot

2010-12-31 Thread Joel Jacobson
2010/12/31 David E. Wheeler > This looks awesome, Joel! One question: Why the dependence on pg_crypto? If > it's just for SHA1 support, and you're just using it to to create hashes of > function bodies, I suspect that you could also use the core MD5() function, > yes? > Thanks for fast reply. My

Re: [HACKERS] contrib/snapshot

2010-12-31 Thread David E. Wheeler
On Dec 31, 2010, at 5:00 AM, Joel Jacobson wrote: > Happy new year fellow pgsql-hackers! > > This is the first alpha release of a new hopefully quite interesting little > tool, named "snapshot". > > Feedback welcomed. This looks awesome, Joel! One question: Why the dependence on pg_crypto? If

[HACKERS] contrib/snapshot

2010-12-31 Thread Joel Jacobson
Happy new year fellow pgsql-hackers! This is the first alpha release of a new hopefully quite interesting little tool, named "snapshot". Feedback welcomed. -- Best regards, Joel Jacobson Glue Finance URL https://github.com/gluefinance/snapshot DESCRIPTION Take a snapshot or rollback al