Re: [HACKERS] dblink: add polymorphic functions.

2016-03-11 Thread Joe Conway
On 03/11/2016 08:51 AM, Robert Haas wrote: > Thanks for understanding. Rejecting patches is not much more fun that > getting your patches rejected, but it's got to be done... sorry! +1 Sorry I didn't already do this myself when it became clear I wasn't going to get it done in time. --

Re: [HACKERS] dblink: add polymorphic functions.

2016-03-11 Thread Robert Haas
On Fri, Mar 11, 2016 at 8:44 AM, Joe Conway wrote: > On 03/11/2016 08:31 AM, Robert Haas wrote: >> On Thu, Jan 28, 2016 at 6:12 AM, Alvaro Herrera >> wrote: >>> Joe Conway wrote: >>> Ok, back to the drawing board. Thanks for the feedback. >>>

Re: [HACKERS] dblink: add polymorphic functions.

2016-03-11 Thread Joe Conway
On 03/11/2016 08:31 AM, Robert Haas wrote: > On Thu, Jan 28, 2016 at 6:12 AM, Alvaro Herrera > wrote: >> Joe Conway wrote: >> >>> Ok, back to the drawing board. Thanks for the feedback. >> >> Closing this one as returned-with-feedback. Please do resubmit for >> CF

Re: [HACKERS] dblink: add polymorphic functions.

2016-03-11 Thread Robert Haas
On Thu, Jan 28, 2016 at 6:12 AM, Alvaro Herrera wrote: > Joe Conway wrote: > >> Ok, back to the drawing board. Thanks for the feedback. > > Closing this one as returned-with-feedback. Please do resubmit for > CF 2016-03. Joe, it looks like you reactivated this patch

Re: [HACKERS] dblink: add polymorphic functions.

2016-01-28 Thread Alvaro Herrera
Joe Conway wrote: > Ok, back to the drawing board. Thanks for the feedback. Closing this one as returned-with-feedback. Please do resubmit for CF 2016-03. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services --

Re: [HACKERS] dblink: add polymorphic functions.

2016-01-17 Thread Joe Conway
On 01/08/2016 07:31 AM, Tom Lane wrote: > Alvaro Herrera writes: >> So, is this going anywhere? > > Oh, sorry, was I on the hook to review that? > > [ quick look... ] This doesn't seem like it responds to my criticism > above. I think what we want is that for every

Re: [HACKERS] dblink: add polymorphic functions.

2016-01-08 Thread Alvaro Herrera
Joe Conway wrote: > On 07/30/2015 09:51 AM, Tom Lane wrote: > > Joe Conway writes: > >> What about just TYPE then? > > > >> SELECT x::TYPE(some_expression) FROM ... > >> SELECT CAST (x AS TYPE(some_expression)) FROM ... > > > The main limitation of this patch is that

Re: [HACKERS] dblink: add polymorphic functions.

2016-01-08 Thread Tom Lane
Alvaro Herrera writes: > Joe Conway wrote: >> On 07/30/2015 09:51 AM, Tom Lane wrote: >>> The main limitation of this patch is that it won't work for call sites >>> that pass pstate == NULL to LookupTypeName. There are a fair number >>> of them, some of which wouldn't

Re: [HACKERS] dblink: add polymorphic functions.

2015-10-17 Thread Joe Conway
On 07/30/2015 09:51 AM, Tom Lane wrote: > Joe Conway writes: >> What about just TYPE then? > >> SELECT x::TYPE(some_expression) FROM ... >> SELECT CAST (x AS TYPE(some_expression)) FROM ... > The main limitation of this patch is that it won't work for call sites >

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-30 Thread Tom Lane
Joe Conway m...@joeconway.com writes: What about just TYPE then? SELECT x::TYPE(some_expression) FROM ... SELECT CAST (x AS TYPE(some_expression)) FROM ... Yeah, that would work. Quick-hack proof-of-concept patch attached. Some usage examples in the regression database: regression=#

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-30 Thread Alvaro Herrera
Tom Lane wrote: Joe Conway m...@joeconway.com writes: What about just TYPE then? SELECT x::TYPE(some_expression) FROM ... SELECT CAST (x AS TYPE(some_expression)) FROM ... Yeah, that would work. Quick-hack proof-of-concept patch attached. I'm amazed that this works without

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-30 Thread Tom Lane
Alvaro Herrera alvhe...@2ndquadrant.com writes: Tom Lane wrote: Yeah, that would work. Quick-hack proof-of-concept patch attached. This is a rather ugly, but I guess not untenable. I suppose we don't care about any actual typmod, do we?. We get the type and typmod both from the expression.

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-29 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/29/2015 08:56 AM, Corey Huinker wrote: On Wed, Jul 29, 2015 at 10:48 AM, Tom Lane t...@sss.pgh.pa.us Not sure why inserting a variable name is so much better than inserting a type name? In a polymorphic function, I don't know the return

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-29 Thread Corey Huinker
On Wed, Jul 29, 2015 at 12:14 PM, Joe Conway m...@joeconway.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/29/2015 08:56 AM, Corey Huinker wrote: On Wed, Jul 29, 2015 at 10:48 AM, Tom Lane t...@sss.pgh.pa.us Not sure why inserting a variable name is so much better than

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-29 Thread Corey Huinker
On Wed, Jul 29, 2015 at 10:48 AM, Tom Lane t...@sss.pgh.pa.us wrote: Corey Huinker corey.huin...@gmail.com writes: On Wed, Jul 29, 2015 at 3:48 AM, Heikki Linnakangas hlinn...@iki.fi wrote: Let's pursue the CAST(srf() AS row_rtype) syntax that Joe suggested upthread (

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-29 Thread Tom Lane
Corey Huinker corey.huin...@gmail.com writes: On Wed, Jul 29, 2015 at 10:48 AM, Tom Lane t...@sss.pgh.pa.us wrote: Not sure why inserting a variable name is so much better than inserting a type name? In a polymorphic function, I don't know the return type. It's whatever type was specified on

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-29 Thread Merlin Moncure
On Wed, Jul 29, 2015 at 12:53 PM, Joe Conway m...@joeconway.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/29/2015 09:40 AM, Corey Huinker wrote: Say I've got a table my_partitioned_table (key1 integer, key2 integer, metric1 integer, metric2 integer); And I've got many

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-29 Thread Tom Lane
Merlin Moncure mmonc...@gmail.com writes: On Wed, Jul 29, 2015 at 12:53 PM, Joe Conway m...@joeconway.com wrote: Ok, gotcha. So Tom's nearby comment about allowing the p_rowtype%TYPE syntax to be used in the CAST is spot on (as usual). In other words, to get a complete solution for you we

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-29 Thread Corey Huinker
Ok, gotcha. So Tom's nearby comment about allowing the p_rowtype%TYPE syntax to be used in the CAST is spot on (as usual). In other words, to get a complete solution for you we would need to make both things work, so you could do this inside plpgsql: select * from cast(dblink(connstr,

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-29 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/29/2015 09:40 AM, Corey Huinker wrote: Say I've got a table my_partitioned_table (key1 integer, key2 integer, metric1 integer, metric2 integer); And I've got many partitions on that table. My code lets you do something like this: select

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-29 Thread Tom Lane
I wrote: Well, it would depend on how we fixed %TYPE, but my thought is that we should teach the core parser to accept variable%TYPE anywhere that a suitable variable is in scope. The core already allows related syntaxes in some utility commands, but not within DML commands. I poked at this

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-29 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/29/2015 05:13 PM, Tom Lane wrote: What's possibly more palatable is to introduce some other special notation for obtain the type of this expression at parse time. I'm thinking for example about SELECT x::pg_typeof(some_expression) FROM ...

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-29 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/29/2015 07:58 PM, Tom Lane wrote: We can definitely do SELECT x::any_single_unreserved_word(some_expression) FROM ... because that's actually not something the grammar needs to distinguish from type-with-a-typmod; we can deal with the

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-29 Thread Tom Lane
Joe Conway m...@joeconway.com writes: On 07/29/2015 05:13 PM, Tom Lane wrote: What's possibly more palatable is to introduce some other special notation for obtain the type of this expression at parse time. I'm thinking for example about SELECT x::pg_typeof(some_expression) FROM ... You

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-29 Thread Heikki Linnakangas
On 07/18/2015 01:32 AM, Corey Huinker wrote: So this patch would result in less C code while still adding 3 new functions. Can anyone think of why that wouldn't be the best way to go? Let's pursue the CAST(srf() AS row_rtype) syntax that Joe suggested upthread

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-29 Thread Tom Lane
Corey Huinker corey.huin...@gmail.com writes: On Wed, Jul 29, 2015 at 3:48 AM, Heikki Linnakangas hlinn...@iki.fi wrote: Let's pursue the CAST(srf() AS row_rtype) syntax that Joe suggested upthread ( http://www.postgresql.org/message-id/559a9643.9070...@joeconway.com). For some reason, the

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-29 Thread Corey Huinker
On Wed, Jul 29, 2015 at 3:48 AM, Heikki Linnakangas hlinn...@iki.fi wrote: On 07/18/2015 01:32 AM, Corey Huinker wrote: So this patch would result in less C code while still adding 3 new functions. Can anyone think of why that wouldn't be the best way to go? Let's pursue the CAST(srf() AS

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-17 Thread Corey Huinker
On Wed, Jul 8, 2015 at 12:21 PM, Joe Conway m...@joeconway.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/08/2015 08:51 AM, Corey Huinker wrote: Questions: Would moving rowtype to the first parameter resolve the parameter ambiguity issue? Not for the existing functions

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-08 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/07/2015 10:22 PM, Michael Paquier wrote: On Mon, Jul 6, 2015 at 11:52 PM, Joe Conway m...@joeconway.com wrote: That explains why the first example works while the second does not. I'm not sure how hard it would be to fix that, but it

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-08 Thread Merlin Moncure
On Wed, Jul 8, 2015 at 10:12 AM, Joe Conway m...@joeconway.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/07/2015 10:22 PM, Michael Paquier wrote: On Mon, Jul 6, 2015 at 11:52 PM, Joe Conway m...@joeconway.com wrote: That explains why the first example works while the second

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-08 Thread Pavel Stehule
2015-07-08 17:12 GMT+02:00 Joe Conway m...@joeconway.com: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/07/2015 10:22 PM, Michael Paquier wrote: On Mon, Jul 6, 2015 at 11:52 PM, Joe Conway m...@joeconway.com wrote: That explains why the first example works while the second does

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-08 Thread Corey Huinker
On Wed, Jul 8, 2015 at 11:29 AM, Merlin Moncure mmonc...@gmail.com wrote: On Wed, Jul 8, 2015 at 10:12 AM, Joe Conway m...@joeconway.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/07/2015 10:22 PM, Michael Paquier wrote: On Mon, Jul 6, 2015 at 11:52 PM, Joe Conway

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-08 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/08/2015 08:51 AM, Corey Huinker wrote: Questions: Would moving rowtype to the first parameter resolve the parameter ambiguity issue? Not for the existing functions but with new functions I don't think it matters. You would know to always

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-07 Thread Michael Paquier
On Mon, Jul 6, 2015 at 11:52 PM, Joe Conway m...@joeconway.com wrote: That explains why the first example works while the second does not. I'm not sure how hard it would be to fix that, but it appears that that is where we should focus. Wouldn't it be fine if we drop some of the functions

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-06 Thread Michael Paquier
On Mon, Jul 6, 2015 at 4:23 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Mon, Jul 6, 2015 at 10:00 AM, Joe Conway m...@joeconway.com wrote: I wonder if it isn't better to just loop through all the args with get_fn_expr_argtype() every time and then test for the exact signature

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-06 Thread Merlin Moncure
On Thu, Feb 19, 2015 at 4:06 PM, Corey Huinker corey.huin...@gmail.com wrote: In the course of writing a small side project which hopefully will make its way onto pgxn soon, I was writing functions that had a polymorphic result set. create function foo( p_row_type anyelement, p_param1 ...)

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-06 Thread Merlin Moncure
On Mon, Jul 6, 2015 at 11:13 AM, Corey Huinker corey.huin...@gmail.com wrote: On Mon, Jul 6, 2015 at 11:33 AM, Merlin Moncure mmonc...@gmail.com wrote: On Mon, Jul 6, 2015 at 9:52 AM, Joe Conway m...@joeconway.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/06/2015 07:37

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-06 Thread Corey Huinker
On Mon, Jul 6, 2015 at 3:52 PM, Merlin Moncure mmonc...@gmail.com wrote: On Mon, Jul 6, 2015 at 11:13 AM, Corey Huinker corey.huin...@gmail.com wrote: On Mon, Jul 6, 2015 at 11:33 AM, Merlin Moncure mmonc...@gmail.com wrote: On Mon, Jul 6, 2015 at 9:52 AM, Joe Conway m...@joeconway.com

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-06 Thread Corey Huinker
On Mon, Jul 6, 2015 at 11:33 AM, Merlin Moncure mmonc...@gmail.com wrote: On Mon, Jul 6, 2015 at 9:52 AM, Joe Conway m...@joeconway.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/06/2015 07:37 AM, Merlin Moncure wrote: yup, and at least one case now fails where

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-06 Thread Corey Huinker
On Sun, Jul 5, 2015 at 9:00 PM, Joe Conway m...@joeconway.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/05/2015 12:25 PM, Joe Conway wrote: On 02/22/2015 10:26 PM, Corey Huinker wrote: Changes in this patch: - added polymorphic versions of dblink_fetch() - upped dblink

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-06 Thread Michael Paquier
On Mon, Jul 6, 2015 at 4:25 AM, Joe Conway m...@joeconway.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/22/2015 10:26 PM, Corey Huinker wrote: Changes in this patch: - added polymorphic versions of dblink_fetch() - upped dblink version # to 1.2 because of new functions -

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-06 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/06/2015 07:37 AM, Merlin Moncure wrote: yup, and at least one case now fails where previously it ran through: postgres=# select * from dblink('a', 'b', 'c'); ERROR: function dblink(unknown, unknown, unknown) is not unique Hmm, that is an

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-06 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/06/2015 12:39 AM, Michael Paquier wrote: Yeah, particularly the use of first_optarg makes things harder to follow in the code with this patch. A C wrapper has the disadvantage to decentralize the argument checks to many places making the

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-06 Thread Corey Huinker
On Mon, Jul 6, 2015 at 10:08 AM, Joe Conway m...@joeconway.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/06/2015 12:39 AM, Michael Paquier wrote: Yeah, particularly the use of first_optarg makes things harder to follow in the code with this patch. A C wrapper has the

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-06 Thread Merlin Moncure
On Mon, Jul 6, 2015 at 9:52 AM, Joe Conway m...@joeconway.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/06/2015 07:37 AM, Merlin Moncure wrote: yup, and at least one case now fails where previously it ran through: postgres=# select * from dblink('a', 'b', 'c'); ERROR:

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-06 Thread Merlin Moncure
On Mon, Jul 6, 2015 at 9:35 AM, Tom Lane t...@sss.pgh.pa.us wrote: Joe Conway m...@joeconway.com writes: Actually, I had in mind something like: 8- inti; intnumargs; int *argtypes; numargs = PG_NARGS(); argtypes = palloc(numargs * sizeof(int)); for (i = 0; i

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-06 Thread Tom Lane
Joe Conway m...@joeconway.com writes: Actually, I had in mind something like: 8- inti; intnumargs; int *argtypes; numargs = PG_NARGS(); argtypes = palloc(numargs * sizeof(int)); for (i = 0; i numargs; i++) argtypes[i] =

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-05 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/22/2015 10:26 PM, Corey Huinker wrote: Changes in this patch: - added polymorphic versions of dblink_fetch() - upped dblink version # to 1.2 because of new functions - migration 1.1 - 1.2 - DocBook changes for dblink(), dblink_get_result(),

Re: [HACKERS] dblink: add polymorphic functions - review

2015-07-05 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/18/2015 09:57 PM, Pavel Stehule wrote: 2015-06-19 6:32 GMT+02:00 Thomas Munro thomas.mu...@enterprisedb.com mailto:thomas.mu...@enterprisedb.com: On Fri, Jun 19, 2015 at 4:17 PM, Pavel Stehule pavel.steh...@gmail.com

Re: [HACKERS] dblink: add polymorphic functions.

2015-07-05 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/05/2015 12:25 PM, Joe Conway wrote: On 02/22/2015 10:26 PM, Corey Huinker wrote: Changes in this patch: - added polymorphic versions of dblink_fetch() - upped dblink version # to 1.2 because of new functions - migration 1.1 - 1.2 - DocBook

[HACKERS] dblink: add polymorphic functions - review

2015-06-18 Thread Pavel Stehule
Hi I am trying to check your patch - but diffs that you sent to mailing list are inconsistent. Please, can you send one complete patch? Regards Pavel

Re: [HACKERS] dblink: add polymorphic functions - review

2015-06-18 Thread Pavel Stehule
2015-06-19 6:32 GMT+02:00 Thomas Munro thomas.mu...@enterprisedb.com: On Fri, Jun 19, 2015 at 4:17 PM, Pavel Stehule pavel.steh...@gmail.com wrote: I am sorry. I didn't the original mail in my mailbox. There is a (rather well hidden) way to ask Majordomo to send you a message that arrived

Re: [HACKERS] dblink: add polymorphic functions - review

2015-06-18 Thread Thomas Munro
On Fri, Jun 19, 2015 at 4:17 PM, Pavel Stehule pavel.steh...@gmail.com wrote: I am sorry. I didn't the original mail in my mailbox. There is a (rather well hidden) way to ask Majordomo to send you a message that arrived before you subscribed, so that you can reply without creating a new thread.

Re: [HACKERS] dblink: add polymorphic functions - review

2015-06-18 Thread Pavel Stehule
2015-06-19 2:17 GMT+02:00 Michael Paquier michael.paqu...@gmail.com: On Thu, Jun 18, 2015 at 10:44 PM, Pavel Stehule pavel.steh...@gmail.com wrote: Hi I am trying to check your patch - but diffs that you sent to mailing list are inconsistent. Please, can you send one complete patch?

Re: [HACKERS] dblink: add polymorphic functions - review

2015-06-18 Thread Michael Paquier
On Thu, Jun 18, 2015 at 10:44 PM, Pavel Stehule pavel.steh...@gmail.com wrote: Hi I am trying to check your patch - but diffs that you sent to mailing list are inconsistent. Please, can you send one complete patch? In order to follow more easily the thread of this patch, could you answer

Re: [HACKERS] dblink: add polymorphic functions.

2015-02-22 Thread Corey Huinker
Changes in this patch: - added polymorphic versions of dblink_fetch() - upped dblink version # to 1.2 because of new functions - migration 1.1 - 1.2 - DocBook changes for dblink(), dblink_get_result(), dblink_fetch() On Sun, Feb 22, 2015 at 11:38 PM, Corey Huinker corey.huin...@gmail.com wrote:

Re: [HACKERS] dblink: add polymorphic functions.

2015-02-22 Thread Corey Huinker
Yes, that was it, I discovered it myself and should have posted a nevermind. Now I'm slogging through figuring out where to find elog() messages from the temporary server. It's slow, but it's progress. On Sun, Feb 22, 2015 at 10:39 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Mon,

Re: [HACKERS] dblink: add polymorphic functions.

2015-02-22 Thread Corey Huinker
I seem to be getting tripped up in the regression test. This line was found in regression.diff + ERROR: could not stat file /home/ubuntu/src/postgres/contrib/dblink/tmp_check/install/usr/local/pgsql/share/extension/dblink--1.2.sql: No such file or directory The file dblink--1.2.sql does exist

Re: [HACKERS] dblink: add polymorphic functions.

2015-02-22 Thread Corey Huinker
nevermind. Found it. On Sun, Feb 22, 2015 at 11:18 PM, Corey Huinker corey.huin...@gmail.com wrote: Yes, that was it, I discovered it myself and should have posted a nevermind. Now I'm slogging through figuring out where to find elog() messages from the temporary server. It's slow, but it's

Re: [HACKERS] dblink: add polymorphic functions.

2015-02-22 Thread Michael Paquier
On Mon, Feb 23, 2015 at 12:03 PM, Corey Huinker corey.huin...@gmail.com wrote: + ERROR: could not stat file /home/ubuntu/src/postgres/contrib/dblink/tmp_check/install/usr/local/pgsql/share/extension/dblink--1.2.sql: No such file or directory Didn't you forget to add dblink--1.2.sql to DATA in

[HACKERS] dblink: add polymorphic functions.

2015-02-19 Thread Corey Huinker
In the course of writing a small side project which hopefully will make its way onto pgxn soon, I was writing functions that had a polymorphic result set. create function foo( p_row_type anyelement, p_param1 ...) returns setof anyelement Inside that function would be multiple calls to dblink()

Re: [HACKERS] dblink: add polymorphic functions.

2015-02-19 Thread Michael Paquier
On Fri, Feb 20, 2015 at 2:50 PM, Corey Huinker corey.huin...@gmail.com wrote: Thanks - completely new to this process, so I'm going to need walking-through of it. I promise to document what I learn and try to add that to the commitfest wiki. Where can I go for guidance about documentation

Re: [HACKERS] dblink: add polymorphic functions.

2015-02-19 Thread Corey Huinker
Thanks - completely new to this process, so I'm going to need walking-through of it. I promise to document what I learn and try to add that to the commitfest wiki. Where can I go for guidance about documentation format and regression tests? Author field is presently being finicky, reported that

Re: [HACKERS] dblink: add polymorphic functions.

2015-02-19 Thread Michael Paquier
On Fri, Feb 20, 2015 at 7:06 AM, Corey Huinker corey.huin...@gmail.com wrote: Proposed patch attached. At quick glance, this patch lacks two things: - regression test coverage - documentation (Note: do not forget to add your name in the field Author when adding a new patch in the CF app). --