Re: [HACKERS] duplicate #define
On 12/13/2014 04:45 PM, Mark Dilger wrote: In commit 2c03216d831160bedd72d45f712601b6f7d03f1c, the following define occurs twice in src/include/access/xlogrecord.h: #define SizeOfXLogRecordDataHeaderLong (sizeof(uint8) + sizeof(uint32)) It is no big deal, as the definitions don't contradict each other. We could probably live with just one, though. Patch attached Thanks, fixed! - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] duplicate #define
In commit 2c03216d831160bedd72d45f712601b6f7d03f1c, the following define occurs twice in src/include/access/xlogrecord.h: #define SizeOfXLogRecordDataHeaderLong (sizeof(uint8) + sizeof(uint32)) It is no big deal, as the definitions don't contradict each other. We could probably live with just one, though. Patch attached Mark Dilger diff --git a/src/include/access/xlogrecord.h b/src/include/access/xlogrecord.h index 11ddfac..fbfad5f 100644 --- a/src/include/access/xlogrecord.h +++ b/src/include/access/xlogrecord.h @@ -174,7 +174,4 @@ typedef struct XLogRecordDataHeaderLong #define XLR_BLOCK_ID_DATA_SHORT255 #define XLR_BLOCK_ID_DATA_LONG 254 -#define SizeOfXLogRecordDataHeaderLong (sizeof(uint8) + sizeof(uint32)) - - #endif /* XLOGRECORD_H */ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] duplicate define in elog.h
Tom Lane wrote: > Joe Conway <[EMAIL PROTECTED]> writes: > > I was looking through elog.h and noticed this at about line 36: > > #define ERROR 20 /* user error - abort transaction; return > > * to known state */ > > #define ERROR 20 /* user error - abort transaction; return > > * to known state */ > > Good catch. Looks like it snuck in here: > http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/include/utils/elog.h.diff?r1=1.41&r2=1.42 Man, I am unsafe with a command prompt. :-) -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings
Re: [HACKERS] duplicate define in elog.h
Joe Conway <[EMAIL PROTECTED]> writes: > I was looking through elog.h and noticed this at about line 36: > #define ERROR 20 /* user error - abort transaction; return >* to known state */ > #define ERROR 20 /* user error - abort transaction; return >* to known state */ Good catch. Looks like it snuck in here: http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/include/utils/elog.h.diff?r1=1.41&r2=1.42 regards, tom lane ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
[HACKERS] duplicate define in elog.h
I was looking through elog.h and noticed this at about line 36: #define ERROR 20 /* user error - abort transaction; return * to known state */ #define ERROR 20 /* user error - abort transaction; return * to known state */ Joe ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
