Re: [HACKERS] elog vs errmsg_internal

2017-08-03 Thread Tom Lane
Peter Eisentraut writes: > Is there a preferred method to select between using elog() and > errmsg_internal()? ereport(... errmsg_internal() ...) can be a win for debug messages that are in hot code paths, because the test for whether the message will get printed is able to short-circuit more wor

Re: [HACKERS] elog vs errmsg_internal

2017-08-03 Thread Alvaro Herrera
Peter Eisentraut wrote: > Is there a preferred method to select between using elog() and > errmsg_internal()? > > Attached is a patch that converts some DEBUG messages to one of those > two to remove them from translation, but I'm not sure which one to pick > other than by random aesthetics. I th

[HACKERS] elog vs errmsg_internal

2017-08-03 Thread Peter Eisentraut
Is there a preferred method to select between using elog() and errmsg_internal()? Attached is a patch that converts some DEBUG messages to one of those two to remove them from translation, but I'm not sure which one to pick other than by random aesthetics. -- Peter Eisentraut http:/