subject:"\[HACKERS\] fd,c just Assert\(\)s that lseek\(\) succeeds"

Re: [HACKERS] fd,c just Assert()s that lseek() succeeds

2017-02-20 Thread Tom Lane

I wrote: > I noticed while researching bug #14555 that fd.c contains two separate > cases like > vfdP->seekPos = lseek(vfdP->fd, (off_t) 0, SEEK_CUR); > Assert(vfdP->seekPos != (off_t) -1); > This seems, um, unwise. It might somehow fail to fail in production > builds, because

[HACKERS] fd,c just Assert()s that lseek() succeeds

2017-02-19 Thread Tom Lane

I noticed while researching bug #14555 that fd.c contains two separate cases like vfdP->seekPos = lseek(vfdP->fd, (off_t) 0, SEEK_CUR); Assert(vfdP->seekPos != (off_t) -1); This seems, um, unwise. It might somehow fail to fail in production builds, because elsewhere it's assumed