Re: [HACKERS] fix ecpg core dump when there's a very long struct variable name in .pgc file

2012-11-25 Thread Chen Huajun
How on earth did you run into this? :) ooh, first I saw the code accidentally,it looks a bit dangerous and differents from the function ECPGdump_a_simple() above, And then I tried to write a test to raise some errors. Thanks for your comment,I will add the patch into commitfest later. It

Re: [HACKERS] fix ecpg core dump when there's a very long struct variable name in .pgc file

2012-11-25 Thread Michael Meskes
On Sun, Nov 25, 2012 at 08:02:33PM +0800, Chen Huajun wrote: Thanks for your comment,I will add the patch into commitfest later. No need for that, the patch is already committed to the archive. It maybe my first patch for open source. It definitely is then. Michael -- Michael Meskes Michael

Re: [HACKERS] fix ecpg core dump when there's a very long struct variable name in .pgc file

2012-11-25 Thread Chen Huajun
(2012/11/25 22:18), Michael Meskes wrote: On Sun, Nov 25, 2012 at 08:02:33PM +0800, Chen Huajun wrote: Thanks for your comment,I will add the patch into commitfest later. No need for that, the patch is already committed to the archive. Oh,I got it,Thanks! -- Regards, Chen Huajun --

Re: [HACKERS] fix ecpg core dump when there's a very long struct variable name in .pgc file

2012-11-23 Thread Michael Meskes
On Thu, Nov 22, 2012 at 06:09:20PM +0800, Chen Huajun wrote: When use a struct variable whose name length is very very long such as 12KB in .pgc source, ecpg will core dump because of buffer overflow if precompile the .pgc file. How on earth did you run into this? :) I absolutely agree that

Re: [HACKERS] fix ecpg core dump when there's a very long struct variable name in .pgc file

2012-11-22 Thread Chen Huajun
sorry,There's a miss(with out free memory) in that patch sended just now, and resend it. Best Regards, Chen Huajun (2012/11/22 18:09), Chen Huajun wrote: hi I found a small bug in ecpg command and try to fix it. Please check if it is correct. When use a struct variable whose name length