Re: [HACKERS] fixes for the Danish locale

2016-07-26 Thread Bjorn Munch
On 21/07 08.42, Jeff Janes wrote: > In Danish, the sequence 'aa' is sometimes treated as a single letter > which collates after 'z'. For the record: this is also true for Norwegian, in both locales it collates equal to 'Ã¥' which is the 29th letter of the alphabet. But 'aa' is no longer used in or

Re: [HACKERS] fixes for the Danish locale

2016-07-22 Thread Noah Misch
On Thu, Jul 21, 2016 at 03:53:45PM -0400, Andrew Dunstan wrote: > > > On 07/21/2016 02:26 PM, Greg Stark wrote: > >On Thu, Jul 21, 2016 at 5:44 PM, Tom Lane wrote: > >>Confirmed here. Will deal with it, but I wonder why we have no buildfarm > >>members covering this ... > >We're not going to ha

Re: [HACKERS] fixes for the Danish locale

2016-07-22 Thread Andreas Karlsson
On 07/22/2016 03:59 AM, Jeff Janes wrote: On Thu, Jul 21, 2016 at 2:11 PM, Tom Lane wrote: I see that the core tests fall over in Turkish still :-( Turkish has never passed (at least back to 9.0). It looks like it is in the stemming functions. I don't understand why, I would think everythin

Re: [HACKERS] fixes for the Danish locale

2016-07-22 Thread Tom Lane
Jeff Janes writes: > The attached patch fixes regression tests for Welsh (cy_GB), needed in > 9.5 and 9.6. Pushed, thanks. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresq

Re: [HACKERS] fixes for the Danish locale

2016-07-22 Thread Jeff Janes
On Thu, Jul 21, 2016 at 11:49 AM, Jeff Janes wrote: > On Thu, Jul 21, 2016 at 9:44 AM, Tom Lane wrote: >> Jeff Janes writes: >>> In Danish, the sequence 'aa' is sometimes treated as a single letter >>> which collates after 'z'. >>> Some regression tests got into 9.5, and are still in 9.6beta3, w

Re: [HACKERS] fixes for the Danish locale

2016-07-21 Thread Tom Lane
Jeff Janes writes: > On Thu, Jul 21, 2016 at 2:11 PM, Tom Lane wrote: >> I see that the core tests fall over in Turkish still :-( > Turkish has never passed (at least back to 9.0). It looks like it is > in the stemming functions. I don't understand why, I would think > everything other than En

Re: [HACKERS] fixes for the Danish locale

2016-07-21 Thread Jeff Janes
On Thu, Jul 21, 2016 at 2:11 PM, Tom Lane wrote: > Jeff Janes writes: >> In Danish, the sequence 'aa' is sometimes treated as a single letter >> which collates after 'z'. >> Some regression tests got into 9.5, and are still in 9.6beta3, which >> fail due to assuming they know how things will sort

Re: [HACKERS] fixes for the Danish locale

2016-07-21 Thread Tom Lane
Jeff Janes writes: > In Danish, the sequence 'aa' is sometimes treated as a single letter > which collates after 'z'. > Some regression tests got into 9.5, and are still in 9.6beta3, which > fail due to assuming they know how things will sort or compare. As of HEAD, "LANG=danish make check-world"

Re: [HACKERS] fixes for the Danish locale

2016-07-21 Thread Andrew Dunstan
On 07/21/2016 02:26 PM, Greg Stark wrote: On Thu, Jul 21, 2016 at 5:44 PM, Tom Lane wrote: Confirmed here. Will deal with it, but I wonder why we have no buildfarm members covering this ... We're not going to have a build farm member for every locale the local systems support. Perhaps the

Re: [HACKERS] fixes for the Danish locale

2016-07-21 Thread Peter Geoghegan
On Thu, Jul 21, 2016 at 11:49 AM, Jeff Janes wrote: > Does testing in other locales ever uncover bugs other than those in > the tests themselves? Is it worth trying to maintain broad coverage? Potentially, yes. The strxfrm() inconsistency issue disproportionately affected de_DE.utf8, for example

Re: [HACKERS] fixes for the Danish locale

2016-07-21 Thread Peter Geoghegan
On Thu, Jul 21, 2016 at 11:44 AM, Tom Lane wrote: > Note that there are certain locales we've deliberately chosen not to > support in some regression tests (see e.g. plpython_unicode.sql), so > I'm not really willing to buy into the idea that "any random locale found > on a buildfarm animal should

Re: [HACKERS] fixes for the Danish locale

2016-07-21 Thread Jeff Janes
On Thu, Jul 21, 2016 at 9:44 AM, Tom Lane wrote: > Jeff Janes writes: >> In Danish, the sequence 'aa' is sometimes treated as a single letter >> which collates after 'z'. >> Some regression tests got into 9.5, and are still in 9.6beta3, which >> fail due to assuming they know how things will sort

Re: [HACKERS] fixes for the Danish locale

2016-07-21 Thread Tom Lane
Peter Geoghegan writes: > On Thu, Jul 21, 2016 at 11:29 AM, Tom Lane wrote: >> Nah, we have a hard enough time with reproducibility of buildfarm results >> without deliberately injecting transient failures. > It could be pseudo-random, and so deterministic per buildfarm animal. > That's what I d

Re: [HACKERS] fixes for the Danish locale

2016-07-21 Thread Peter Geoghegan
On Thu, Jul 21, 2016 at 11:29 AM, Tom Lane wrote: >> Perhaps the build farm script should pick a random locale for each >> run. Either a random locale from the set on the OS or a random >> language from a list of locale that the regression tests are intended >> to be safe for. > > Nah, we have a h

Re: [HACKERS] fixes for the Danish locale

2016-07-21 Thread Tom Lane
Greg Stark writes: > On Thu, Jul 21, 2016 at 5:44 PM, Tom Lane wrote: >> Confirmed here. Will deal with it, but I wonder why we have no buildfarm >> members covering this ... > We're not going to have a build farm member for every locale the local > systems support. Probably not, but Danish se

Re: [HACKERS] fixes for the Danish locale

2016-07-21 Thread Peter Geoghegan
On Thu, Jul 21, 2016 at 11:26 AM, Greg Stark wrote: > Perhaps the build farm script should pick a random locale for each > run. Either a random locale from the set on the OS or a random > language from a list of locale that the regression tests are intended > to be safe for. That's more or less w

Re: [HACKERS] fixes for the Danish locale

2016-07-21 Thread Greg Stark
On Thu, Jul 21, 2016 at 5:44 PM, Tom Lane wrote: > > Confirmed here. Will deal with it, but I wonder why we have no buildfarm > members covering this ... We're not going to have a build farm member for every locale the local systems support. Perhaps the build farm script should pick a random lo

Re: [HACKERS] fixes for the Danish locale

2016-07-21 Thread Tom Lane
Jeff Janes writes: > In Danish, the sequence 'aa' is sometimes treated as a single letter > which collates after 'z'. > Some regression tests got into 9.5, and are still in 9.6beta3, which > fail due to assuming they know how things will sort or compare. Confirmed here. Will deal with it, but I

[HACKERS] fixes for the Danish locale

2016-07-21 Thread Jeff Janes
In Danish, the sequence 'aa' is sometimes treated as a single letter which collates after 'z'. Some regression tests got into 9.5, and are still in 9.6beta3, which fail due to assuming they know how things will sort or compare. I thought the easiest way to deal with it was just to change the test