Re: [HACKERS] fixing dllist?

2007-03-22 Thread Alvaro Herrera
Another change that could be done to Dllist is removing the Dllist pointer from the Dlelem struct: Index: src/include/lib/dllist.h === RCS file: /home/alvherre/Code/cvs/pgsql/src/include/lib/dllist.h,v retrieving revision 1.27 diff

Re: [HACKERS] fixing dllist?

2007-03-22 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: Another change that could be done to Dllist is removing the Dllist pointer from the Dlelem struct: I think this is a bad idea. The patch you propose makes CatCacheRemoveCTup significantly more expensive (extra hash calculation). Moreover, the savings

[HACKERS] fixing dllist?

2007-03-21 Thread Alvaro Herrera
Hi, While coding the autovacuum stuff I noticed that the dllist.c doubly linked list infrastructure is using malloc(). And the failure cases are handled in #ifdef FRONTEND exit(1) #else elog(ERROR) #endif. This seems a bit ugly, but more importantly, it doesn't let me free the whole list by

Re: [HACKERS] fixing dllist?

2007-03-21 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: Hi, While coding the autovacuum stuff I noticed that the dllist.c doubly linked list infrastructure is using malloc(). And the failure cases are handled in #ifdef FRONTEND exit(1) #else elog(ERROR) #endif. This seems a bit ugly, but more importantly,