Re: [HACKERS] gcc 4.6 -Wunused-but-set-variable

2011-06-16 Thread Peter Eisentraut
On ons, 2011-06-15 at 19:28 -0400, Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: I couldn't see a way good way of programming around this (perhaps in the second case, but it would get uselessly ugly), so perhaps just marking the variables as potentially unused would be

[HACKERS] gcc 4.6 -Wunused-but-set-variable

2011-06-15 Thread Peter Eisentraut
Another set of new gcc 4.6 warnings: readfuncs.c: In function ‘_readCaseWhen’: readfuncs.c:875:567: warning: variable ‘token’ set but not used [-Wunused-but-set-variable] readfuncs.c: In function ‘_readFromExpr’: readfuncs.c:1159:568: warning: variable ‘token’ set but not used

Re: [HACKERS] gcc 4.6 -Wunused-but-set-variable

2011-06-15 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: I couldn't see a way good way of programming around this (perhaps in the second case, but it would get uselessly ugly), so perhaps just marking the variables as potentially unused would be appropriate? See patch. Of course this would break not only on