Re: [HACKERS] git cherry-pick timestamping issue

2010-09-24 Thread Tom Lane
I wrote: > Apparently somebody's confused between local and GMT time somewhere in > there. For the archives' sake: this turns out to be a portability issue not handled by the git code. If you are running on a platform old enough to have gmtime_r returning int rather than struct tm *, you need thi

Re: [HACKERS] git cherry-pick timestamping issue

2010-09-23 Thread Tom Lane
Abhijit Menon-Sen writes: > I'm using 1.7.3, yes. It has a bunch of timezone handling changes, but > I'm not sure if there's anything related to your problem. If you don't > have TZ set in your environment, I suppose the following patch *could* > be relevant, since you're in -0400 and I'm in +0530

Re: [HACKERS] git cherry-pick timestamping issue

2010-09-23 Thread Alvaro Herrera
Excerpts from Robert Haas's message of jue sep 23 17:36:07 -0400 2010: > >> Obviously, all committers must now relocate to the UK. > > > > Yes, move here.  I'll put the kettle on. > > I'm not sure that's the simplest solution to the problem at hand, but > I'm game... Hey, if it comes to that, I'

Re: [HACKERS] git cherry-pick timestamping issue

2010-09-23 Thread Abhijit Menon-Sen
At 2010-09-23 17:37:51 -0400, t...@sss.pgh.pa.us wrote: > > Hm. What git version are you using? I'm using 1.7.3, yes. It has a bunch of timezone handling changes, but I'm not sure if there's anything related to your problem. If you don't have TZ set in your environment, I suppose the following pa

Re: [HACKERS] git cherry-pick timestamping issue

2010-09-23 Thread Tom Lane
Abhijit Menon-Sen writes: > At 2010-09-23 15:52:24 -0400, t...@sss.pgh.pa.us wrote: >> This is with a vanilla build of 1.7.2.3. Anybody else see this type >> of symptom? > Not me. I just tried various combinations of commit in one branch and > cherry-pick in another, and the timestamp stays corr

Re: [HACKERS] git cherry-pick timestamping issue

2010-09-23 Thread Robert Haas
On Thu, Sep 23, 2010 at 5:22 PM, Thom Brown wrote: > On 23 September 2010 22:20, David E. Wheeler wrote: >> On Sep 23, 2010, at 1:02 PM, Robert Haas wrote: >> >>> On Thu, Sep 23, 2010 at 3:52 PM, Tom Lane wrote: Apparently somebody's confused between local and GMT time somewhere in the

Re: [HACKERS] git cherry-pick timestamping issue

2010-09-23 Thread Abhijit Menon-Sen
At 2010-09-23 15:52:24 -0400, t...@sss.pgh.pa.us wrote: > > Apparently somebody's confused between local and GMT time somewhere in > there. > > This is with a vanilla build of 1.7.2.3. Anybody else see this type > of symptom? Not me. I just tried various combinations of commit in one branch and c

Re: [HACKERS] git cherry-pick timestamping issue

2010-09-23 Thread Joshua D. Drake
On Thu, 2010-09-23 at 22:22 +0100, Thom Brown wrote: > On 23 September 2010 22:20, David E. Wheeler wrote: > > On Sep 23, 2010, at 1:02 PM, Robert Haas wrote: > > > >> On Thu, Sep 23, 2010 at 3:52 PM, Tom Lane wrote: > >>> Apparently somebody's confused between local and GMT time somewhere in > >

Re: [HACKERS] git cherry-pick timestamping issue

2010-09-23 Thread Thom Brown
On 23 September 2010 22:20, David E. Wheeler wrote: > On Sep 23, 2010, at 1:02 PM, Robert Haas wrote: > >> On Thu, Sep 23, 2010 at 3:52 PM, Tom Lane wrote: >>> Apparently somebody's confused between local and GMT time somewhere in >>> there. >> >> Ouch.  That rather sucks. > > Obviously, all comm

Re: [HACKERS] git cherry-pick timestamping issue

2010-09-23 Thread David E. Wheeler
On Sep 23, 2010, at 1:02 PM, Robert Haas wrote: > On Thu, Sep 23, 2010 at 3:52 PM, Tom Lane wrote: >> Apparently somebody's confused between local and GMT time somewhere in >> there. > > Ouch. That rather sucks. Obviously, all committers must now relocate to the UK. Best, David -- Sent v

Re: [HACKERS] git cherry-pick timestamping issue

2010-09-23 Thread Robert Haas
On Thu, Sep 23, 2010 at 3:52 PM, Tom Lane wrote: > Apparently somebody's confused between local and GMT time somewhere in > there. Ouch. That rather sucks. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-h

[HACKERS] git cherry-pick timestamping issue

2010-09-23 Thread Tom Lane
So my first attempt at using git cherry-pick didn't go so well. The commit in master looks like commit ee63981c1fe26299162b9c7f1218d7e3ef802409 Author: Tom Lane Date: Thu Sep 23 15:34:56 2010 -0400 Avoid sharing subpath list structure when flattening nested AppendRels. which is the co