Re: [HACKERS] heap_update temporary release of buffer lock

2011-09-27 Thread Robert Haas
On Tue, Sep 20, 2011 at 3:47 PM, Tom Lane t...@sss.pgh.pa.us wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Robert Haas's message of mar sep 20 16:04:03 -0300 2011: On 20.09.2011 20:42, Alvaro Herrera wrote: I notice that heap_update releases the buffer lock, after

[HACKERS] heap_update temporary release of buffer lock

2011-09-20 Thread Alvaro Herrera
I notice that heap_update releases the buffer lock, after checking the HeapTupleSatifiesUpdate result, and before marking the tuple as updated, to pin the visibility map page -- heapam.c lines 2638ff in master branch. Is this not a bug? I imagine that while this code releases the lock, someone

Re: [HACKERS] heap_update temporary release of buffer lock

2011-09-20 Thread Heikki Linnakangas
On 20.09.2011 20:42, Alvaro Herrera wrote: I notice that heap_update releases the buffer lock, after checking the HeapTupleSatifiesUpdate result, and before marking the tuple as updated, to pin the visibility map page -- heapam.c lines 2638ff in master branch. Is this not a bug? I imagine that

Re: [HACKERS] heap_update temporary release of buffer lock

2011-09-20 Thread Robert Haas
On Tue, Sep 20, 2011 at 2:28 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: On 20.09.2011 20:42, Alvaro Herrera wrote: I notice that heap_update releases the buffer lock, after checking the HeapTupleSatifiesUpdate result, and before marking the tuple as updated, to pin the

Re: [HACKERS] heap_update temporary release of buffer lock

2011-09-20 Thread Alvaro Herrera
Excerpts from Robert Haas's message of mar sep 20 16:04:03 -0300 2011: On Tue, Sep 20, 2011 at 2:28 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: On 20.09.2011 20:42, Alvaro Herrera wrote: I notice that heap_update releases the buffer lock, after checking the

Re: [HACKERS] heap_update temporary release of buffer lock

2011-09-20 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Robert Haas's message of mar sep 20 16:04:03 -0300 2011: On 20.09.2011 20:42, Alvaro Herrera wrote: I notice that heap_update releases the buffer lock, after checking the HeapTupleSatifiesUpdate result, and before marking the