Re: [HACKERS] macports and brew postgresql --universal builds

2012-08-14 Thread Peter Eisentraut
On 8/10/12 7:12 PM, Doug Coleman wrote: What it looks like is the first line of each section is pattern matching. If __LP64__ is defined, then it's a 64-bit architecture, and we want to use the top part of the if statement. The #defines they target seem to be all of the ones that are different

[HACKERS] macports and brew postgresql --universal builds

2012-08-10 Thread Doug Coleman
The MacPorts Project (http://www.macports.org/) supports building universal binaries (32/64bit binaries in one file) for most projects. For PostgreSQL, they apply two patches after the configure script to correct some of the typedefs. Otherwise, the build fails in compiling a switch statement with

Re: [HACKERS] macports and brew postgresql --universal builds

2012-08-10 Thread Tom Lane
Doug Coleman doug.cole...@gmail.com writes: The MacPorts Project (http://www.macports.org/) supports building universal binaries (32/64bit binaries in one file) for most projects. For PostgreSQL, they apply two patches after the configure script to correct some of the typedefs. Otherwise, the

Re: [HACKERS] macports and brew postgresql --universal builds

2012-08-10 Thread Daniel Farina
On Fri, Aug 10, 2012 at 3:44 PM, Tom Lane t...@sss.pgh.pa.us wrote: The files you link to don't make much sense to me (they do not look like patch diffs) but they seem to suggest hard-wiring configure results into the source code, which does not sound like an acceptable solution from our

Re: [HACKERS] macports and brew postgresql --universal builds

2012-08-10 Thread Doug Coleman
What it looks like is the first line of each section is pattern matching. If __LP64__ is defined, then it's a 64-bit architecture, and we want to use the top part of the if statement. The #defines they target seem to be all of the ones that are different on 32bit platforms. I agree that you

Re: [HACKERS] macports and brew postgresql --universal builds

2012-08-10 Thread Andrew Dunstan
On 08/10/2012 06:44 PM, Tom Lane wrote: Doug Coleman doug.cole...@gmail.com writes: The MacPorts Project (http://www.macports.org/) supports building universal binaries (32/64bit binaries in one file) for most projects. For PostgreSQL, they apply two patches after the configure script to