Re: [HACKERS] more-helpful-izing a debug message
On 2015-08-04 16:38:58 -0400, Robert Haas wrote: On Wed, Jul 8, 2015 at 5:38 AM, Marko Tiikkaja ma...@joh.to wrote: One of the debug messages related to logical replication could be more helpful than it currently is. The attached patch reorders the two operations to make it so. Please consider patching and back-patching. Andres, this looks like a bug fix to me. What do you think? Yes, definitely. Sorry for letting this fall by the wayside. Pushed. Regards, Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] more-helpful-izing a debug message
On Wed, Jul 8, 2015 at 5:38 AM, Marko Tiikkaja ma...@joh.to wrote: One of the debug messages related to logical replication could be more helpful than it currently is. The attached patch reorders the two operations to make it so. Please consider patching and back-patching. Andres, this looks like a bug fix to me. What do you think? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] more-helpful-izing a debug message
Hi, One of the debug messages related to logical replication could be more helpful than it currently is. The attached patch reorders the two operations to make it so. Please consider patching and back-patching. .m diff --git a/src/backend/replication/logical/logical.c b/src/backend/replication/logical/logical.c index 824bc91..7643add 100644 --- a/src/backend/replication/logical/logical.c +++ b/src/backend/replication/logical/logical.c @@ -406,11 +406,12 @@ CreateDecodingContext(XLogRecPtr start_lsn, * decoding. Clients have to be able to do that to support synchronous * replication. */ - start_lsn = slot-data.confirmed_flush; elog(DEBUG1, cannot stream from %X/%X, minimum is %X/%X, forwarding, (uint32) (start_lsn 32), (uint32) start_lsn, (uint32) (slot-data.confirmed_flush 32), (uint32) slot-data.confirmed_flush); + + start_lsn = slot-data.confirmed_flush; } ctx = StartupDecodingContext(output_plugin_options, -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers