[HACKERS] more buildfarm breakage

2011-02-04 Thread Robert Haas
mingw is unhappy with my latest stab at fixing the mess created by the errcodes patch last night. It appears that there are several files in src/port that include postgres.h even when FRONTEND is defined. For example, chklocale.c does this, which looks good: #ifndef FRONTEND #include postgres.h

Re: [HACKERS] more buildfarm breakage

2011-02-04 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: mingw is unhappy with my latest stab at fixing the mess created by the errcodes patch last night. It appears that there are several files in src/port that include postgres.h even when FRONTEND is defined. For example, chklocale.c does this, which

Re: [HACKERS] more buildfarm breakage

2011-02-04 Thread Robert Haas
On Fri, Feb 4, 2011 at 1:04 PM, Tom Lane t...@sss.pgh.pa.us wrote: I agree, that is not cool. OK, changed. BTW, I noted here that errcodes.h doesn't seem to get built till after src/port/ is built.  That seems wrong --- there is definitely code in there that needs to throw errors. It does,

Re: [HACKERS] more buildfarm breakage

2011-02-04 Thread Robert Haas
On Fri, Feb 4, 2011 at 1:16 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, Feb 4, 2011 at 1:04 PM, Tom Lane t...@sss.pgh.pa.us wrote: I agree, that is not cool. OK, changed. It looks like pipe.c is full of backend-specific error-reporting code. I could rewrite it to work in the