Re: [HACKERS] msvc build fails in Japanese environment

2009-12-30 Thread Magnus Hagander 
2009/12/30 Hiroshi Inoue in...@tpf.co.jp:
 Hi,

 I try to build msvc version of postgres using the current cvs and
  get the following error.

  Unable to determine vcbuild version from first line of output! at
  src/tools/msvc/Solution.pm line 70.

 The error comes from the following output of vcbuild /? in my
  environment.

  Microsoft(R) Visual C++ Project Builder - コマンド ライン バージョン 8.00.50727

 The Command Line Version part is localized.
 In addtion there's no space between Mircrosoft and (R).

How typical of Microsoft to localize different strings in different languages :S

Since this is not the first time we've run into issues specifically
with the Japanese version of Windows, perhaps we should try to get a
japanese buildfarm member running?

Is this something you could help with? Or somebody else from our
Japanese community?


 The attahced patch fixes the error in my environment.

Applied, thanks.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] msvc build fails in Japanese environment

2009-12-29 Thread Hiroshi Inoue 

Hi,

I try to build msvc version of postgres using the current cvs and
 get the following error.

 Unable to determine vcbuild version from first line of output! at
 src/tools/msvc/Solution.pm line 70.

The error comes from the following output of vcbuild /? in my
 environment.

 Microsoft(R) Visual C++ Project Builder - コマンド ライン バージョン 
8.00.50727


The Command Line Version part is localized.
In addtion there's no space between Mircrosoft and (R).

The attahced patch fixes the error in my environment.

regards,
Hiroshi Inoue
Index: Solution.pm
===
RCS file: /projects/cvsroot/pgsql/src/tools/msvc/Solution.pm,v
retrieving revision 1.49
diff -c -r1.49 Solution.pm
*** Solution.pm 23 Dec 2009 13:27:04 -  1.49
--- Solution.pm 29 Dec 2009 23:47:43 -
***
*** 66,72 
  open(P,vcbuild /? |) || die vcbuild command not found;
  my $line = P;
  close(P);
! if ($line !~ /^Microsoft \(R\) Visual C\+\+ Project Builder - Command 
Line Version (\d+)\.00\.\d+/) {
 die Unable to determine vcbuild version from first line of output!;
  }
  if ($1 == 8) { $self-{vcver} = '8.00' }
--- 66,72 
  open(P,vcbuild /? |) || die vcbuild command not found;
  my $line = P;
  close(P);
! if ($line !~ /^Microsoft\s*\(R\) Visual C\+\+ Project Builder - 
\D+(\d+)\.00\.\d+/) {
 die Unable to determine vcbuild version from first line of output!;
  }
  if ($1 == 8) { $self-{vcver} = '8.00' }

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers