Re: [HACKERS] not null validation option in contrib/file_fdw

2012-06-21 Thread Etsuro Fujita
To: 'Andrew Dunstan'; 'Shigeru HANADA' Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] not null validation option in contrib/file_fdw I updated the patch. Attached is an updated version of the patch. Changes: * fix a bug in fileGetOptions() * rename the validation option and its

Re: [HACKERS] not null validation option in contrib/file_fdw

2012-04-16 Thread Etsuro Fujita
: [HACKERS] not null validation option in contrib/file_fdw On 04/13/2012 07:21 AM, Shigeru HANADA wrote: (2012/04/13 16:59), Etsuro Fujita wrote: I updated the patch added to CF 2012-Next [1]. Attached is the updated version of the patch. I applied the patch and ran regression tests

Re: [HACKERS] not null validation option in contrib/file_fdw

2012-04-16 Thread Etsuro Fujita
[mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Etsuro Fujita Sent: Monday, April 16, 2012 4:09 PM To: 'Andrew Dunstan'; 'Shigeru HANADA' Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] not null validation option in contrib/file_fdw Thank you for the review. -Original

[HACKERS] not null validation option in contrib/file_fdw

2012-04-13 Thread Etsuro Fujita
I updated the patch added to CF 2012-Next [1]. Attached is the updated version of the patch. For the discussion in [2], I've introduced a new generic option, validate for file_fdw foreign tables, which specifies if file_fdw verifies that tuples meet NOT NULL constraints. The default value for

Re: [HACKERS] not null validation option in contrib/file_fdw

2012-04-13 Thread Shigeru HANADA
(2012/04/13 16:59), Etsuro Fujita wrote: I updated the patch added to CF 2012-Next [1]. Attached is the updated version of the patch. I applied the patch and ran regression tests of file_fdw, and I got SIGSEGV X-( The failure occurs in fileGetOptions, and it is caused by list_delete_cell used

Re: [HACKERS] not null validation option in contrib/file_fdw

2012-04-13 Thread Andrew Dunstan
On 04/13/2012 07:21 AM, Shigeru HANADA wrote: (2012/04/13 16:59), Etsuro Fujita wrote: I updated the patch added to CF 2012-Next [1]. Attached is the updated version of the patch. I applied the patch and ran regression tests of file_fdw, and I got SIGSEGV X-( The failure occurs in